Skip to content

Updates related to adding TPU-like design to VTR benchmarks #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aman26kbm opened this issue Nov 8, 2020 · 3 comments
Closed

Updates related to adding TPU-like design to VTR benchmarks #1590

aman26kbm opened this issue Nov 8, 2020 · 3 comments
Assignees
Labels

Comments

@aman26kbm
Copy link
Contributor

PR #1573 resulted in adding a TPU-like design to the VTR benchmark suite. But there are some action items that need to be done. Filing an issue to track these. @aman26kbm will work on these items.

Pasting actions from @vaughnbetz 's comments in that PR:

#1: Adding tests
For tests, I suggest

#2: Adding testbench
if we make each benchmark a sub-directory I am pretty sure it will break the existing vtr_flow scripts that will run the regtests above. That could be fixed, but the faster way to check in the testbenches would be to make a /testbenches directory under the vtr_flow/benchmarks/verilog directory and put a README and testbenches (or subdirectories with testbenches) under it.

#3: Adding the design to CI/QoR regression
Seems like these should be added to the benchmarks/verilog directory and run as part of the vtr suite during QoR runs then.

#4: Managing ML benchmarks
I think we can make a benchmarks/ml directory and just put a README in it pointing to the designs in benchmarks/verilog and later titan/. That way we don't have to add a lot of new tests, and we can run these new designs alongside the existing Odin-II compatible designs (with our current scripts) and average QoR across the larger suite.
Basically this groups designs by the flow they go through, and then READMEs/lists define subsets and combinations of interest. I think that will be the more maintainable solution.

#5: Fixing/removing engineer, company, etc. in the banner of the design
Probably should either fill in as much of this as possible (engineer, company can be institution, etc.) or delete this.

@vaughnbetz
Copy link
Contributor

Assigning to Aman.

Copy link

github-actions bot commented May 9, 2025

This issue has been inactive for a year and has been marked as stale. It will be closed in 15 days if it continues to be stale. If you believe this is still an issue, please add a comment.

@github-actions github-actions bot added the Stale label May 9, 2025
Copy link

This issue has been marked stale for 15 days and has been automatically closed.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants