Skip to content

Bug in ezxml #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kmurray opened this issue Jun 26, 2015 · 4 comments
Closed

Bug in ezxml #14

kmurray opened this issue Jun 26, 2015 · 4 comments
Assignees

Comments

@kmurray
Copy link
Contributor

kmurray commented Jun 26, 2015

Originally reported on Google Code with ID 21

We are not currently using the latest version of ezxml.  There is a bug in the version
we are using when adding tags out of order.  The code segfaults.

I tested with the latest version of ezxml and it corrected the problem.  

I encountered it using the following architecture snippet:

                <interconnect>
                    <direct name="direct1" input="ble.in" output="soft_logic.in"/>
                    <mux name="mux1" input="soft_logic.out[1:1] soft_logic.out[0:0]" output="ff[0:0].D"/>
                    <mux name="mux2" input="soft_logic.out[0:0] ff[0:0].Q" output="ble.out[0:0]"/>
                    <mux name="mux3" input="soft_logic.out[1:1] ff[0:0].Q" output="ble.out[1:1]"/>
                    <direct name="direct4" input="ble.clk" output="ff[0:0].clk"/>                                       
                </interconnect>

Reported by jeffrey.goeders on 2012-05-08 00:46:51

@kmurray
Copy link
Contributor Author

kmurray commented Jun 26, 2015

To clarify, the bug is due to the fact that the 'direct' and 'mux' types are mixed,
instead of grouped.  Mixing will not always cause the bug - only certain orderings
will do so.

This is a known issue in past versions of ezxml.

Reported by jeffrey.goeders on 2012-05-08 00:48:02

@kmurray kmurray self-assigned this Jun 26, 2015
@kmurray
Copy link
Contributor Author

kmurray commented Jun 26, 2015

Actually, I mistakenly thought I tested with the new ezxml.  In fact I did not.

I didn't realize we had modified the ezxml.c file.  Perhaps our modifications are the
source of the bug.  Diffing the latest version of ezxml with our version, I only notice
the locations that we have changed.

For now we should just be careful in how we write architecture files.

Reported by jeffrey.goeders on 2012-05-08 18:44:50

@kmurray
Copy link
Contributor Author

kmurray commented Jun 26, 2015

When I get the newest ezxml, add in the line numbers update, and run, it seg faults.
 Will probably need to do what Ted Campbell did to fix the numerous memory access bugs
in ezxml if we want to use the newest version.

Reported by JasonKaiLuu on 2012-05-09 20:23:17

@kmurray
Copy link
Contributor Author

kmurray commented Aug 26, 2016

Fixed in 33e01c8, as ezxml has been replaced with the more robust pugixml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant