ODIN_II: Fix coverity issue CID 200770: Resource leak

j-b-1-7 · j-b-1-7 · commit ec1819627d77 · 2019-07-20T12:11:44.000-03:00
diff --git a/ODIN_II/SRC/netlist_visualizer.cpp b/ODIN_II/SRC/netlist_visualizer.cpp
@@ -310,7 +310,6 @@ void forward_traversal_net_graph_display(FILE *fp, short marker_value, nnode_t *
 
 /*---------------------------------------------------------------------------------------------
  * (function: backward_traversal_net_graph_display()
- *	TODO check if stack of node is freed
  *-------------------------------------------------------------------------------------------*/
 void backward_traversal_net_graph_display(FILE *fp, short marker_value, nnode_t *node)
 {
@@ -393,4 +392,9 @@ void backward_traversal_net_graph_display(FILE *fp, short marker_value, nnode_t
 		/* process next element in net */
 		index_in_stack ++;
 	}
+	for(int i = 0; i < num_stack_of_nodes; i++)
+	{
+		free_nnode(stack_of_nodes[i]);
+	}
+	vtr::free(stack_of_nodes);
 }

Original file line number	Diff line number	Diff line change
`@@ -310,7 +310,6 @@ void forward_traversal_net_graph_display(FILE fp, short marker_value, nnode_t `
`310`	`310`
`311`	`311`	`/*---------------------------------------------------------------------------------------------`
`312`	`312`	`* (function: backward_traversal_net_graph_display()`
`313`		`- * TODO check if stack of node is freed`
`314`	`313`	`-------------------------------------------------------------------------------------------/`
`315`	`314`	`void backward_traversal_net_graph_display(FILE fp, short marker_value, nnode_t node)`
`316`	`315`	`{`
`@@ -393,4 +392,9 @@ void backward_traversal_net_graph_display(FILE *fp, short marker_value, nnode_t`
`393`	`392`	`/* process next element in net */`
`394`	`393`	`index_in_stack ++;`
`395`	`394`	`}`
	`395`	`+ for(int i = 0; i < num_stack_of_nodes; i++)`
	`396`	`+ {`
	`397`	`+ free_nnode(stack_of_nodes[i]);`
	`398`	`+ }`
	`399`	`+ vtr::free(stack_of_nodes);`
`396`	`400`	`}`