Skip to content

Commit ec0d4dc

Browse files
Fix comments in greedy_seed_selector to refer to molecules instead of atoms
1 parent bb2bcb9 commit ec0d4dc

File tree

2 files changed

+9
-11
lines changed

2 files changed

+9
-11
lines changed

vpr/src/pack/greedy_seed_selector.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ GreedySeedSelector::GreedySeedSelector(const AtomNetlist& atom_netlist,
175175
const LogicalModels& models,
176176
const PreClusterTimingManager& pre_cluster_timing_manager)
177177
: seed_mols_(prepacker.molecules().begin(), prepacker.molecules().end()) {
178-
// Seed atoms list is initialized with all atoms in the atom netlist.
178+
// Seed molecule list is initialized with all molecule in the netlist.
179179

180180
// Pre-compute the criticality of each atom
181181
// Default criticalities set to zero (e.g. if not timing driven)
@@ -188,8 +188,8 @@ GreedySeedSelector::GreedySeedSelector(const AtomNetlist& atom_netlist,
188188
}
189189
}
190190

191-
// Maintain a lookup table of the seed gain for each atom. This will be
192-
// used to sort the seed atoms.
191+
// Maintain a lookup table of the seed gain for each molecule. This will be
192+
// used to sort the seed molecules.
193193
// Initially all gains are zero.
194194
vtr::vector<PackMoleculeId, float> molecule_gains(seed_mols_.size(), 0.f);
195195

@@ -236,20 +236,20 @@ GreedySeedSelector::GreedySeedSelector(const AtomNetlist& atom_netlist,
236236

237237
// Set the starting seed index (the index of the first molecule to propose).
238238
// The index of the first seed to propose is the first molecule in the
239-
// seed atoms vector (i.e. the one with the highest seed gain).
239+
// seed molecules vector (i.e. the one with the highest seed gain).
240240
seed_index_ = 0;
241241
}
242242

243243
PackMoleculeId GreedySeedSelector::get_next_seed(const ClusterLegalizer& cluster_legalizer) {
244244
while (seed_index_ < seed_mols_.size()) {
245-
// Get the current seed atom at the seed index and increment the
245+
// Get the current seed molecule at the seed index and increment the
246246
// seed index.
247247
// All previous seed indices have been either proposed already or
248248
// are already clustered. This process assumes that once an atom
249249
// is clustered it will never become unclustered.
250250
PackMoleculeId seed_molecule_id = seed_mols_[seed_index_++];
251251

252-
// If this atom has been clustered, it cannot be proposed as a seed.
252+
// If this molecule has been clustered, it cannot be proposed as a seed.
253253
// Skip to the next seed.
254254
if (cluster_legalizer.is_mol_clustered(seed_molecule_id)) {
255255
continue;
@@ -258,7 +258,7 @@ PackMoleculeId GreedySeedSelector::get_next_seed(const ClusterLegalizer& cluster
258258
}
259259

260260
// If the previous loop does not return a molecule, it implies that all
261-
// atoms have been clustered or have already been proposed as a seed.
261+
// molecule have been clustered or have already been proposed as a seed.
262262
// Return nullptr to signify that there are no further seeds.
263263
return PackMoleculeId::INVALID();
264264
}

vpr/src/pack/greedy_seed_selector.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,20 +68,18 @@ class GreedySeedSelector {
6868
* This method assumes that once a molecule is clustered, it will never be
6969
* unclustered.
7070
*
71-
* @param prepacker
72-
* The prepacker object that stores the molecules.
7371
* @param cluster_legalizer
7472
* The cluster legalizer object that is used to create the
7573
* clusters. This is used to check if a molecule has already
7674
* been clustered or not.
7775
*/
7876
PackMoleculeId get_next_seed(const ClusterLegalizer& cluster_legalizer);
7977

80-
// TODO: Maybe create an update_seed_gains method to update the seed atoms
78+
// TODO: Maybe create an update_seed_gains method to update the seed molecules
8179
// list using current clustering information.
8280

8381
private:
84-
/// @brief The index of the next seed to propose in the seed_atoms vector.
82+
/// @brief The index of the next seed to propose in the seed_mols_ vector.
8583
/// This is set to 0 in the constructor and incremented as more seeds
8684
/// are proposed.
8785
size_t seed_index_;

0 commit comments

Comments
 (0)