Skip to content

Commit d81fe02

Browse files
[CI] Cleaned Up How Artifacts Are Saved
When artifacts were being saved for the regression tests, it was saving all of the benchmarks as blif files. This is incredibly wasteful (72 MB per regression test or around 720 MB per CI run). These tests will no longer save .blif files as artifacts anymore. If anyone needed these files they could generate them themselves or can add a condition to add the exact .blif files they may need. The CI was also always generating artifacts (at least for the nightly tests) even when the run was cancelled. Made it so the artifacts are only saved if the run is not cancelled. This would mean an artifact is generated if the run succeeds or fails.
1 parent 41072d4 commit d81fe02

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

.github/workflows/test.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,10 @@ jobs:
8686
NUM_CORES: ${{ matrix.cores }}
8787

8888
- name: Upload test results
89-
# We always want the test results to be uploaded, even when cancelled.
89+
# If the job was not cancelled, we want to save the result (this includes
90+
# when the job fails). See warning here:
9091
# https://docs.github.com/en/actions/learn-github-actions/expressions#always
91-
if: ${{ always() }}
92+
if: ${{ !cancelled() }}
9293
# TODO: This runnner is running on a self-hosted CPU. In order to upgrade
9394
# to v4, need to upgrade the machine to support node20.
9495
uses: actions/upload-artifact@v3
@@ -275,17 +276,19 @@ jobs:
275276
./run_reg_test.py ${{ matrix.suite }} -show_failures -j2
276277
277278
- name: Upload regression run files
279+
if: ${{ !cancelled() }}
278280
uses: actions/upload-artifact@v4
279281
with:
280282
name: ${{matrix.name}}_run_files
281283
path: |
282284
vtr_flow/**/*.out
283-
vtr_flow/**/*.blif
285+
# vtr_flow/**/*.blif # Removed since it was taking too much space and was hardly used.
284286
vtr_flow/**/*.p
285287
vtr_flow/**/*.net
286288
vtr_flow/**/*.r
287289
288290
- name: Upload regression results
291+
if: ${{ !cancelled() }}
289292
uses: actions/upload-artifact@v4
290293
with:
291294
name: ${{matrix.name}}_results

0 commit comments

Comments
 (0)