rename ERROR_TOL to PL_INCREMENTAL_COST_TOLERANCE

Author: soheilshahrouz

vpr/src/place/net_cost_handler.cpp

@@ -1688,10 +1688,10 @@ void NetCostHandler::recompute_costs_from_scratch(const PlaceDelayModel* delay_m
     auto check_and_print_cost = [](double new_cost,
                                    double old_cost,
                                    const std::string& cost_name) -> void {
-        if (!vtr::isclose(new_cost, old_cost, ERROR_TOL, 0.)) {
+        if (!vtr::isclose(new_cost, old_cost, PL_INCREMENTAL_COST_TOLERANCE, 0.)) {
             std::string msg = vtr::string_fmt(
                 "in recompute_costs_from_scratch: new_%s = %g, old %s = %g, ERROR_TOL = %g\n",
-                cost_name.c_str(), new_cost, cost_name.c_str(), old_cost, ERROR_TOL);
+                cost_name.c_str(), new_cost, cost_name.c_str(), old_cost, PL_INCREMENTAL_COST_TOLERANCE);
             VPR_ERROR(VPR_ERROR_PLACE, msg.c_str());
         }
     };

vpr/src/place/noc_place_utils.cpp

@@ -374,10 +374,10 @@ void NocCostHandler::recompute_costs_from_scratch(const t_noc_opts& noc_opts, t_
     auto check_and_print_cost = [](double new_cost,
                                    double old_cost,
                                    const std::string& cost_name) -> void {
-        if (!vtr::isclose(new_cost, old_cost, ERROR_TOL, 0.)) {
+        if (!vtr::isclose(new_cost, old_cost, PL_INCREMENTAL_COST_TOLERANCE, 0.)) {
             std::string msg = vtr::string_fmt(
                 "in recompute_costs_from_scratch: new_%s = %g, old %s = %g, ERROR_TOL = %g\n",
-                cost_name.c_str(), new_cost, cost_name.c_str(), old_cost, ERROR_TOL);
+                cost_name.c_str(), new_cost, cost_name.c_str(), old_cost, PL_INCREMENTAL_COST_TOLERANCE);
             VPR_ERROR(VPR_ERROR_PLACE, msg.c_str());
         }
     };

vpr/src/place/place.cpp

@@ -1956,7 +1956,7 @@ static void check_place(const t_placer_costs& costs,
 
     if (noc_opts.noc) {
         // check the NoC costs during placement if the user is using the NoC supported flow
-        error += noc_cost_handler->check_noc_placement_costs(costs, ERROR_TOL, noc_opts);
+        error += noc_cost_handler->check_noc_placement_costs(costs, PL_INCREMENTAL_COST_TOLERANCE, noc_opts);
         // make sure NoC routing configuration does not create any cycles in CDG
         error += (int)noc_cost_handler->noc_routing_has_cycle();
     }
@@ -1984,7 +1984,7 @@ static int check_placement_costs(const t_placer_costs& costs,
 
     double bb_cost_check = net_cost_handler.comp_bb_cost(e_cost_methods::CHECK);
 
-    if (fabs(bb_cost_check - costs.bb_cost) > costs.bb_cost * ERROR_TOL) {
+    if (fabs(bb_cost_check - costs.bb_cost) > costs.bb_cost * PL_INCREMENTAL_COST_TOLERANCE) {
         VTR_LOG_ERROR(
             "bb_cost_check: %g and bb_cost: %g differ in check_place.\n",
             bb_cost_check, costs.bb_cost);
@@ -1994,7 +1994,7 @@ static int check_placement_costs(const t_placer_costs& costs,
     if (place_algorithm.is_timing_driven()) {
         comp_td_costs(delay_model, *criticalities, placer_state, &timing_cost_check);
         //VTR_LOG("timing_cost recomputed from scratch: %g\n", timing_cost_check);
-        if (fabs(timing_cost_check - costs.timing_cost) > costs.timing_cost * ERROR_TOL) {
+        if (fabs(timing_cost_check - costs.timing_cost) > costs.timing_cost * PL_INCREMENTAL_COST_TOLERANCE) {
             VTR_LOG_ERROR(
                 "timing_cost_check: %g and timing_cost: %g differ in check_place.\n",
                 timing_cost_check, costs.timing_cost);

vpr/src/place/place_util.h

@@ -18,7 +18,7 @@
  * @brief The error tolerance due to round off for the total cost computation.
  * When we check it from scratch vs. incrementally. 0.01 means that there is a 1% error tolerance.
  */
-constexpr double ERROR_TOL = .01;
+constexpr double PL_INCREMENTAL_COST_TOLERANCE = .01;
 
 // forward declaration of t_placer_costs so that it can be used an argument
 // in NocCostTerms constructor