replace unneccessary "std::string(name)" with just "name"

w0lek · w0lek · commit b62013545fba · 2024-05-21T17:01:23.000+03:00
diff --git a/vpr/src/server/telegramoptions.cpp b/vpr/src/server/telegramoptions.cpp
@@ -75,7 +75,7 @@ int TelegramOptions::get_int(const std::string& name, int fail_value) {
     if (std::optional<int> opt = try_convert_to_int(m_options[name].value)) {
         return opt.value();
     } else {
-        m_errors.emplace_back("cannot get int value for option " + std::string(name));
+        m_errors.emplace_back("cannot get int value for option " + name);
         return fail_value;
     }
 }
@@ -84,7 +84,7 @@ bool TelegramOptions::get_bool(const std::string& name, bool fail_value) {
     if (std::optional<int> opt = try_convert_to_int(m_options[name].value)) {
         return opt.value();
     } else {
-        m_errors.emplace_back("cannot get bool value for option " + std::string(name));
+        m_errors.emplace_back("cannot get bool value for option " + name);
         return fail_value;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ int TelegramOptions::get_int(const std::string& name, int fail_value) {`
`75`	`75`	`if (std::optional<int> opt = try_convert_to_int(m_options[name].value)) {`
`76`	`76`	`return opt.value();`
`77`	`77`	`} else {`
`78`		`- m_errors.emplace_back("cannot get int value for option " + std::string(name));`
	`78`	`+ m_errors.emplace_back("cannot get int value for option " + name);`
`79`	`79`	`return fail_value;`
`80`	`80`	`}`
`81`	`81`	`}`
`@@ -84,7 +84,7 @@ bool TelegramOptions::get_bool(const std::string& name, bool fail_value) {`
`84`	`84`	`if (std::optional<int> opt = try_convert_to_int(m_options[name].value)) {`
`85`	`85`	`return opt.value();`
`86`	`86`	`} else {`
`87`		`- m_errors.emplace_back("cannot get bool value for option " + std::string(name));`
	`87`	`+ m_errors.emplace_back("cannot get bool value for option " + name);`
`88`	`88`	`return fail_value;`
`89`	`89`	`}`
`90`	`90`	`}`