add noexcept to get rid of warnings

Author: soheilshahrouz

libs/EXTERNAL/libezgl/include/ezgl/point.hpp

@@ -36,7 +36,7 @@ class point2d {
   /**
    * Create a point at the given x and y position.
    */
-  point2d(double x_coord, double y_coord) : x(x_coord), y(y_coord)
+  point2d(double x_coord, double y_coord) noexcept : x(x_coord), y(y_coord)
   {
   }
 

libs/EXTERNAL/libezgl/include/ezgl/rectangle.hpp

@@ -33,7 +33,7 @@ class rectangle {
   /**
    * Default constructor: Create a zero-sized rectangle at {0,0}.
    */
-  rectangle() : m_first({0, 0}), m_second({0, 0})
+  rectangle() noexcept : m_first({0, 0}), m_second({0, 0})
   {
   }
 

libs/EXTERNAL/libtatum/libtatum/tatum/util/tatum_strong_id.hpp

@@ -161,7 +161,7 @@ template<typename tag, typename T, T sentinel>
 bool operator!=(const StrongId<tag,T,sentinel>& lhs, const StrongId<tag,T,sentinel>& rhs);
 
 template<typename tag, typename T, T sentinel>
-bool operator<(const StrongId<tag,T,sentinel>& lhs, const StrongId<tag,T,sentinel>& rhs);
+bool operator<(const StrongId<tag,T,sentinel>& lhs, const StrongId<tag,T,sentinel>& rhs) noexcept;
 
 
 //Class template definition with default template parameters
@@ -215,7 +215,7 @@ bool operator!=(const StrongId<tag,T,sentinel>& lhs, const StrongId<tag,T,sentin
 
 //Needed for std::map-like containers
 template<typename tag, typename T, T sentinel>
-bool operator<(const StrongId<tag,T,sentinel>& lhs, const StrongId<tag,T,sentinel>& rhs) {
+bool operator<(const StrongId<tag,T,sentinel>& lhs, const StrongId<tag,T,sentinel>& rhs) noexcept {
     return lhs.id_ < rhs.id_;
 }
 

libs/libarchfpga/src/cad_types.h

@@ -104,7 +104,7 @@ struct t_pack_patterns {
     std::vector<std::vector<t_pb_graph_pin*>> chain_root_pins;
 
     // default constructor initializing to an invalid pack pattern
-    t_pack_patterns() {
+    t_pack_patterns() noexcept {
         name = nullptr;
         index = -1;
         root_block = nullptr;

libs/librrgraph/src/base/rr_graph_utils.h

@@ -21,7 +21,7 @@ struct t_pin_chain_node {
     int nxt_node_idx = OPEN;
 
     t_pin_chain_node() = default;
-    t_pin_chain_node(int pin_num, int nxt_idx)
+    t_pin_chain_node(int pin_num, int nxt_idx) noexcept
         : pin_physical_num(pin_num)
         , nxt_node_idx(nxt_idx) {}
 };

libs/libvtrutil/src/vtr_flat_map.h

@@ -21,7 +21,7 @@ class flat_map2;
  * @brief A function to create a flat map
  *
  * Helper function to create a flat map from a vector of pairs
- * without haveing to explicity specify the key and value types
+ * without having to explicitly specify the key and value types
  */
 template<class K, class V>
 flat_map<K, V> make_flat_map(std::vector<std::pair<K, V>>&& vec) {
@@ -435,7 +435,7 @@ template<class K, class T, class Compare, class Storage>
 class flat_map2 : public flat_map<K, T, Compare, Storage> {
   public:
     ///@brief Constructor
-    flat_map2() {}
+    flat_map2() noexcept {}
     explicit flat_map2(std::vector<typename flat_map2<K, T, Compare, Storage>::value_type>&& values)
         : flat_map<K, T, Compare>(std::move(values)) {}
 

libs/libvtrutil/src/vtr_geometry.h

@@ -119,7 +119,7 @@ template<class T>
 class Rect {
   public: //Constructors
     ///@brief default constructor
-    Rect();
+    Rect() noexcept;
 
     ///@brief construct using 4 vertex
     Rect(T left_val, T bottom_val, T right_val, T top_val);

libs/libvtrutil/src/vtr_geometry.tpp

@@ -86,7 +86,7 @@ Point<T>& Point<T>::operator-=(const Point<T>& rhs) {
  * Rect
  */
 template<class T>
-Rect<T>::Rect()
+Rect<T>::Rect() noexcept
     : Rect<T>(Point<T>(0, 0), Point<T>(0, 0)) {
     //pass
 }

libs/libvtrutil/src/vtr_ndoffsetmatrix.h

@@ -63,7 +63,7 @@ class NdOffsetMatrixProxy {
      *  dim_stride: The stride of this dimension (i.e. how many element in memory between indicies of this dimension)
      *  start: Pointer to the start of the sub-matrix this proxy represents
      */
-    NdOffsetMatrixProxy<T, N>(const DimRange* dim_ranges, size_t idim, size_t dim_stride, T* start)
+    NdOffsetMatrixProxy(const DimRange* dim_ranges, size_t idim, size_t dim_stride, T* start)
         : dim_ranges_(dim_ranges)
         , idim_(idim)
         , dim_stride_(dim_stride)
@@ -116,7 +116,7 @@ class NdOffsetMatrixProxy<T, 1> {
      *     - dim_stride: The stride of this dimension (i.e. how many element in memory between indicies of this dimension)
      *     - start: Pointer to the start of the sub-matrix this proxy represents
      */
-    NdOffsetMatrixProxy<T, 1>(const DimRange* dim_ranges, size_t idim, size_t dim_stride, T* start)
+    NdOffsetMatrixProxy(const DimRange* dim_ranges, size_t idim, size_t dim_stride, T* start)
         : dim_ranges_(dim_ranges)
         , idim_(idim)
         , dim_stride_(dim_stride)

libs/libvtrutil/src/vtr_strong_id.h

@@ -182,11 +182,11 @@ class StrongId {
     static constexpr StrongId INVALID() noexcept { return StrongId(); }
 
     ///@brief Default to the sentinel value
-    constexpr StrongId()
+    constexpr StrongId() noexcept
         : id_(sentinel) {}
 
     ///@brief Only allow explicit constructions from a raw Id (no automatic conversions)
-    explicit constexpr StrongId(T id)
+    explicit constexpr StrongId(T id) noexcept
         : id_(id) {}
 
     // Allow some explicit conversion to useful types:

vpr/src/base/setup_noc.h

@@ -39,7 +39,7 @@
 
 // a data structure to store the position information of a noc router in the FPGA device
 struct t_noc_router_tile_position {
-    t_noc_router_tile_position(int x, int y, int layer_num, float centroid_x, float centroid_y)
+    t_noc_router_tile_position(int x, int y, int layer_num, float centroid_x, float centroid_y) noexcept
         : grid_width_position(x)
         , grid_height_position(y)
         , layer_position(layer_num)

vpr/src/pack/pack_types.h

@@ -69,7 +69,7 @@ struct t_lb_type_rr_node {
     t_pb_graph_pin* pb_graph_pin; /* pb_graph_pin associated with this lb_rr_node if exists, NULL otherwise */
     float intrinsic_cost;         /* cost of this node */
 
-    t_lb_type_rr_node() {
+    t_lb_type_rr_node() noexcept {
         capacity = 0;
         num_modes = 0;
         num_fanout = nullptr;
@@ -130,7 +130,7 @@ struct t_intra_lb_net {
     std::vector<bool> fixed_terminals; /* Marks a terminal as having a fixed target (i.e. a pin not a sink) */
     t_lb_trace* rt_tree;               /* Route tree head */
 
-    t_intra_lb_net() {
+    t_intra_lb_net() noexcept {
         atom_net_id = AtomNetId::INVALID();
         rt_tree = nullptr;
     }

vpr/src/timing/PreClusterDelayCalculator.h

@@ -19,7 +19,7 @@ class PreClusterDelayCalculator : public tatum::DelayCalculator {
     PreClusterDelayCalculator(const AtomNetlist& netlist,
                               const AtomLookup& netlist_lookup,
                               float intercluster_net_delay,
-                              const Prepacker& prepacker)
+                              const Prepacker& prepacker) noexcept
         : netlist_(netlist)
         , netlist_lookup_(netlist_lookup)
         , inter_cluster_net_delay_(intercluster_net_delay)