[Odin] fix env, dockerfile, odin bm

this commit:

- fix makefile to use usr bin env python3
- mimic travis with the dockerfile to allow easier test to replicate
  buildbot and travis bugs
- add a lower bound to the parser

Author: jeanlego

Dockerfile

@@ -1,38 +1,87 @@
-FROM ubuntu:bionic
+FROM ubuntu:trusty as builder
 
-ENV WORKSPACE=/workspace
+RUN apt-get update 
+RUN apt-get install -y \
+    software-properties-common
+
+# add auto gpg key other lauchpad ppa
+RUN add-apt-repository ppa:nilarimogard/webupd8
+RUN apt-get update && apt-get install -y \
+    launchpad-getkeys
+
+# add llvm PPA
+RUN printf "\n\
+deb http://ppa.launchpad.net/george-edison55/precise-backports/ubuntu precise main \n\
+deb http://ppa.launchpad.net/ubuntu-toolchain-r/test/ubuntu trusty main \n\
+deb https://apt.llvm.org/precise llvm-toolchain-precise-3.6 main \n\
+deb https://apt.llvm.org/trusty llvm-toolchain-trusty-6.0 main \n\
+deb https://apt.llvm.org/trusty llvm-toolchain-trusty-7 main \n\
+deb https://apt.llvm.org/trusty llvm-toolchain-trusty-8 main \n\
+" >> /etc/apt/sources.list
 
-RUN apt-get update && \
- apt-get install --no-install-recommends --yes \
-	sudo \
-	build-essential \
-	flex \
-	bison \
-	ccache \
-	ninja \
-	cmake \
-	fontconfig \
-	libcairo2-dev \
-	libfontconfig1-dev \
-	libx11-dev \
-	libxft-dev \
-	libgtk-3-dev \
-	perl \
-	liblist-moreutils-perl \
-	python \
-	time \
-	git \
-	valgrind \
-	gdb \
-	ctags \
-	vim \
-	gcc-7 \
-	libasan4  && \
- apt-get autoremove -y && \
- apt-get clean && \
- rm -rf /var/lib/apt/lists/*
+# grab llvm keys
+RUN launchpad-getkeys
 
+RUN apt-get update
+RUN apt-get install -y \
+    ninja \
+    libssl-dev \
+    autoconf \
+    automake \
+    bash \
+    bison \
+    binutils \
+    binutils-gold \
+    build-essential \
+    ctags \
+    curl \
+    doxygen \
+    flex \
+    fontconfig \
+    gdb \
+    git \
+    gperf \
+    libcairo2-dev \
+    libgtk-3-dev \
+    libevent-dev \
+    libfontconfig1-dev \
+    liblist-moreutils-perl \
+    libncurses5-dev \
+    libx11-dev \
+    libxft-dev \
+    libxml++2.6-dev \
+    perl \
+    python \
+    python-lxml \
+    texinfo \
+    time \
+    valgrind \
+    zip \
+    qt5-default \
+    clang-format-7 \
+    g++-5 \
+    gcc-5 \
+    g++-6 \
+    gcc-6 \
+    g++-7 \
+    gcc-7 \
+    g++-8 \
+    gcc-8 \
+    g++-9 \
+    gcc-9 \
+    clang-6.0 \
+    clang-8
+
+# install CMake
+WORKDIR /tmp
+ENV CMAKE=cmake-3.17.0
+RUN curl -s https://cmake.org/files/v3.17/${CMAKE}.tar.gz | tar xvzf -
+RUN cd ${CMAKE} && ./configure && make && make install
+
+# set out workspace
+ENV WORKSPACE=/workspace
 RUN mkdir -p ${WORKSPACE}
 VOLUME ${WORKSPACE}
+WORKDIR ${WORKSPACE}
 
-ENTRYPOINT [ "/bin/bash" ]
+CMD [ "/bin/bash" ]

ODIN_II/Makefile

@@ -1,5 +1,5 @@
 ODIN_ROOT=$(PWD)
-NB_OF_PROCESS ?= $(shell python -c "import multiprocessing; print(multiprocessing.cpu_count())")
+NB_OF_PROCESS ?= $(shell /usr/bin/env python3 -c "import multiprocessing; print(multiprocessing.cpu_count())")
 
 ################
 # build with ninja when doable

ODIN_II/regression_test/benchmark/task/large/task.conf

@@ -12,10 +12,10 @@ archs_dir=../vtr_flow/arch/timing
 # one arch allows it to run faster given it is single threaded
 arch_list_add=k6_frac_N10_frac_chain_mem32K_40nm.xml
 
-circuits_dir=./
+circuits_dir=./regression_test/benchmark/verilog
 
 # glob the large benchmark and the vtr ones to prevent duplicate run
-circuit_list_add=regression_test/benchmark/verilog/large/*.v
-circuit_list_add=../vtr_flow/benchmarks/verilog/*.v
+circuit_list_add=large/*.v
+circuit_list_add=../../../../vtr_flow/benchmarks/verilog/*.v
 
 synthesis_parse_file=regression_test/parse_result/conf/synth.toml

ODIN_II/regression_test/parse_result/conf/basic.toml

@@ -7,12 +7,16 @@
 ['max_rss(MiB)']
     # Memory usage can be very off depending on the number of cores
     range = [ 0.0, 100.0 ]
+    # we cutoff anything bellow 250 MiB as it is subject to noise
+    cutoff = 250.0
     regex = 'Odin II took .* \(max_rss (\d+|\d+.\d+) MiB\)'
     default = -1
 
 ['exec_time(ms)']
     # timing can be very off due to how fast odin runs
     range = [ 0.0, 100.0 ]
+    # we cutoff anything bellow 1 second as it is subject to noise
+    cutoff = 1000.0
     regex = 'Total time: (\d+|\d+.\d+)ms'
     default = -1
 

ODIN_II/regression_test/parse_result/conf/sim.toml

@@ -10,6 +10,8 @@
     regex = 'Simulation time: (\d+|\d+.\d+)ms'
     # timing can be very off due to how fast odin runs
     range = [ 0.0, 100.0 ]
+    # we cutoff anything bellow 1 second as it is subject to noise
+    cutoff = 1000.0
     default = -1
 
 ['test_coverage(%)']

ODIN_II/regression_test/parse_result/conf/synth.toml

@@ -10,6 +10,8 @@
     regex = 'Elaboration Time: (\d+|\d+.\d+)ms'
     # timing can be very off due to how fast odin runs
     range = [ 0.0, 100.0 ]
+    # we cutoff anything bellow 1 second  as it is subject to noise
+    cutoff = 1000.0
     default = -1
 
 #include node.toml

ODIN_II/regression_test/parse_result/parse_result.py

@@ -10,6 +10,7 @@
 import json
 
 import csv
+import math
 
 c_red='\033[31m'
 c_grn='\033[32m'
@@ -60,6 +61,7 @@ def is_json_str(value):
 _K_KEY='key'
 _K_REGEX='regex'
 _K_RANGE='range'
+_K_CUTOFF='cutoff'
 
 def preproc_toml(file):
     current_dir=os.getcwd()
@@ -231,12 +233,23 @@ def sanity_check(header, toml_dict, golden_tbl, tbl):
 def range(header, toml_dict, golden_tbl, tbl):
     if len(toml_dict[header][_K_RANGE]) != 2:
         print("expected a min and a max for range = [ min, max ]")
+        exit(1)
     elif golden_tbl[header] != tbl[header]:
+
+        low_cutoff = None
+        if _K_CUTOFF in toml_dict[header]:
+            low_cutoff = toml_dict[header][_K_CUTOFF]
+
+        value = float(tbl[header])
         gold_value = float(golden_tbl[header])
+        if low_cutoff is not None:
+            if value < low_cutoff:
+                value = low_cutoff
+            if gold_value < low_cutoff:
+                gold_value = low_cutoff
+
         min_ratio = float(toml_dict[header][_K_RANGE][0])
         max_ratio = float(toml_dict[header][_K_RANGE][1])
-        value = float(tbl[header])
-
         min_range = ( min_ratio * gold_value )
         max_range = ( max_ratio * gold_value )  
         if value < min_range  or value > max_range: