Skip to content

Commit aeddc02

Browse files
harpreetbamrahvaughnbetz
authored andcommitted
Grammatical/spelling corrections
Name addition to Contributors Signed-off-by: Harpreet Kaur <[email protected]>
1 parent 870d06b commit aeddc02

File tree

6 files changed

+33
-33
lines changed

6 files changed

+33
-33
lines changed

ODIN_II/SRC/netlist_create_from_ast.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2745,7 +2745,7 @@ signal_list_t* create_pins(ast_node_t* var_declare, char* name, char* instance_n
27452745

27462746
/*---------------------------------------------------------------------------------------------
27472747
* (function: create_output_pin)
2748-
* Create OUTPUT pin creates a pin representing this naming isntance, adds it to the input
2748+
* Create OUTPUT pin creates a pin representing this naming instance, adds it to the input
27492749
* nets list (if not already there) and adds the pin to the list.
27502750
* Note: only for output drivers...
27512751
*-------------------------------------------------------------------------------------------*/

ODIN_II/SRC/odin_ii.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ static ODIN_ERROR_CODE synthesize_verilog() {
108108
module_names_to_idx = sc_new_string_cache();
109109

110110
/* parse to abstract syntax tree */
111-
printf("Parser starting - we'll create an abstract syntax tree. Note this tree can be viewed using Grap Viz (see documentation)\n");
111+
printf("Parser starting - we'll create an abstract syntax tree. Note this tree can be viewed using GraphViz (see documentation)\n");
112112
verilog_ast = init_parser();
113113
parse_to_ast();
114114
/**

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ Professors: Kenneth Kent, Vaughn Betz, Jonathan Rose, Jason Anderson, Peter Jami
9898
Research Assistants: Aaron Graham
9999

100100

101-
Graduate Students: Kevin Murray, Jason Luu, Oleg Petelin, Xifian Tang, Mohamed Elgammal, Mohamed Eldafrawy, Jeffrey Goeders, Chi Wai Yu, Andrew Somerville, Ian Kuon, Alexander Marquardt, Andy Ye, Wei Mark Fang, Tim Liu, Charles Chiasson, Panagiotis (Panos) Patros, Jean-Philippe Legault, Aaron Graham, Nasrin Eshraghi Ivari, Maria Patrou, Scott Young, Sarah Khalid, Seyed Alireza Damghani
101+
Graduate Students: Kevin Murray, Jason Luu, Oleg Petelin, Xifian Tang, Mohamed Elgammal, Mohamed Eldafrawy, Jeffrey Goeders, Chi Wai Yu, Andrew Somerville, Ian Kuon, Alexander Marquardt, Andy Ye, Wei Mark Fang, Tim Liu, Charles Chiasson, Panagiotis (Panos) Patros, Jean-Philippe Legault, Aaron Graham, Nasrin Eshraghi Ivari, Maria Patrou, Scott Young, Sarah Khalid, Seyed Alireza Damghani, Harpreet Kaur
102102

103103

104104
Summer Students: Opal Densmore, Ted Campbell, Cong Wang, Peter Milankov, Scott Whitty, Michael Wainberg, Suya Liu, Miad Nasr, Nooruddin Ahmed, Thien Yu, Long Yu Wang, Matthew J.P. Walker, Amer Hesson, Sheng Zhong, Hanqing Zeng, Vidya Sankaranarayanan, Jia Min Wang, Eugene Sha, Jean-Philippe Legault, Richard Ren, Dingyu Yang, Alexandrea Demmings, Hillary Soontiens, Julie Brown, Bill Hu, David Baines, Mahshad Farahani, Helen Dai, Daniel Zhai

doc/src/odin/dev_guide/contributing.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ To fix issues or add a new feature submit a PR or WIP PR following the provided
88
**Important** Before creating a Pull Request (PR), if it is a bug you have happened upon and intend to fix make sure you create an issue beforehand.
99

1010
Pull requests are intended to correct bugs and improve Odin's performance.
11-
To create a pull request, clone the vtr-verilog-rooting repository and branch from the master.
11+
To create a pull request, clone the [vtr-verilog-to-routing repository](https://github.com/verilog-to-routing/vtr-verilog-to-routing) and branch from the master.
1212
Make changes to the branch that improve Odin II and correct the bug.
1313
**Important** In addition to correcting the bug, it is required that test cases (benchmarks) are created that reproduce the issue and are included in the regression tests.
1414
An example of a good test case could be the benchmark found in the "Issue" being addressed.
@@ -21,9 +21,9 @@ Add a description of the changes made and reference the "issue" that it corrects
2121
**Important** Before creating a WIP PR, if it is a bug you have happened upon and intend to fix make sure you create an issue beforehand.
2222

2323
A "work in progress" PR is a pull request that isn't complete or ready to be merged.
24-
It is intended to demonstrate that an Issue is being addressed and indicates to other developpers that they don't need to fix it.
25-
Creating a WIP PR is similar to a regular PR with a few adjustements.
26-
First, clone the [vtr-verilog-rooting repository](https://github.com/verilog-to-routing/vtr-verilog-to-routing) and branch from the master.
24+
It is intended to demonstrate that an Issue is being addressed and indicates to other developers that they don't need to fix it.
25+
Creating a WIP PR is similar to a regular PR with a few adjustments.
26+
First, clone the [vtr-verilog-to-routing repository](https://github.com/verilog-to-routing/vtr-verilog-to-routing) and branch from the master.
2727
Make changes to that branch.
2828
Then, create a pull request with that branch and **include WIP in the title.**
2929
This will automatically indicate that this PR is not ready to be merged.

doc/src/odin/dev_guide/regression_test.md

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -5,30 +5,30 @@ Each regression test targets a specific function of Odin II.
55
There are two main components of a regression test; benchmarks and a configuration file.
66
The benchmarks are comprised of verilog files, input vector files and output vector files.
77
The configuration file calls upon each benchmark and synthesizes them with different architectures.
8-
The current regression tests of Odin II can be found in regression_test/benchmarks.
8+
The current regression tests of Odin II can be found in regression_test/benchmark.
99

1010
## Benchmarks
1111

1212
Benchmarks are used to test the functionality of Odin II and ensure that it runs properly.
13-
Benchmarks of Odin II can be found in regression_test/benchmarks/verilog/any_folder.
13+
Benchmarks of Odin II can be found in regression_test/benchmark/verilog/any_folder.
1414
Each benchmark is comprised of a verilog file, an input vector file, and an output vector file.
1515
They are called upon during regression tests and synthesized with different architectures to be compared against the expected results.
16-
These tests are usefull for developers to test the functionality of Odin II after implementing changes.
16+
These tests are useful for developers to test the functionality of Odin II after implementing changes.
1717
The command `make test` runs through all these tests, comparing the results to previously generated results, and should be run through when first installing.
1818

1919
### Unit Benchmarks
2020

21-
Unit Benchmarks are the simplest of benchmarks. They are meant to isolate different functions of Odin II.
21+
Unit benchmarks are the simplest of benchmarks. They are meant to isolate different functions of Odin II.
2222
The goal is that if it does not function properly, the error can be traced back to the function being tested.
2323
This cannot always be achieved as different functions depend on others to work properly.
24-
It is ideal that these benchmarks test bit size capacity, errorenous cases, as well as standards set by the IEEE Standard for Verilog® Hardware Description Language - 2005.
24+
It is ideal that these benchmarks test bit size capacity, erroneous cases, as well as standards set by the IEEE Standard for Verilog® Hardware Description Language - 2005.
2525

2626
### Micro Benchmarks
2727

28-
Micro benchmark's are precise, like unit benchmarks, however are more syntactic.
28+
Micro benchmarks are precise, like unit benchmarks, however are more syntactic.
2929
They are meant to isolate the behaviour of different functions.
3030
They trace the behaviour of functions to ensure they adhere to the IEEE Standard for Verilog® Hardware Description Language - 2005.
31-
Like micro benchmarks, they should check errorenous cases and behavioural standards et by the IEEE Standard for Verilog® Hardware Description Language - 2005.
31+
Like unit benchmarks, they should check erroneous cases and behavioural standards set by the IEEE Standard for Verilog® Hardware Description Language - 2005.
3232

3333
### Macro Benchmarks
3434

@@ -38,10 +38,10 @@ These tests are designed to test things like syntax and more complicated standar
3838

3939
### External Benchmarks
4040

41-
External Benchmarks are benchmarks created by outside users to the project.
41+
External benchmarks are benchmarks created by outside users to the project.
4242
It is possible to pull an outside directory and build them on the fly thus creating a benchmark for Odin II.
4343

44-
## Creating Regression tests
44+
## Creating Regression Tests
4545

4646
### New Regression Test Checklist
4747

@@ -50,7 +50,7 @@ It is possible to pull an outside directory and build them on the fly thus creat
5050
* Create a folder in the task directory for the configuration file [here](#creating-a-task)
5151
* Generate the results [here](#regenerating-results)
5252
* Add the task to a suite (large suite if generating the results takes longer than 3 minutes, otherwise put in light suite) [here](#creating-a-suite)
53-
* Update the documentation by providing a summary in Regression Test Summary section and updating the Directory tree [here](#regression-test-summaries)
53+
* Update the documentation by providing a summary in Regression Test Summary section and updating the Directory Tree [here](#regression-test-summaries)
5454

5555
### New Benchmarks added to Regression Test Checklist
5656

@@ -61,22 +61,22 @@ It is possible to pull an outside directory and build them on the fly thus creat
6161

6262
* verilog file
6363
* input vector file
64-
* expected ouptut vector file
64+
* expected output vector file
6565
* configuration file (conditional)
6666
* architecture file (optional)
6767

6868
### Creating Benchmarks
6969

7070
If only a few benchmarks are needed for a PR, simply add the benchmarks to the appropriate set of regression tests.
71-
[The Regression Test Summary](#regression-test-summaries) summarizes the target of each regression test which may be helpful.
71+
The [Regression Test Summary](#regression-test-summaries) summarizes the target of each regression test which may be helpful.
7272

7373
The standard of naming the benchmarks are as follows:
7474

7575
* verilog file: meaningful_title.v
7676
* input vector file: meaningful_title_input
7777
* output vector file: meaningful_title_output
7878

79-
If the tests needed do not fit in an already existing set of regression tests or need certain architecture(s), create a seperate folder in the verilog directory and label appropriately.
79+
If the tests needed do not fit in an already existing set of regression tests or need certain architecture(s), create a separate folder in the verilog directory and label appropriately.
8080
Store the benchmarks in that folder.
8181
Add the architecture (if it isn't one that already exists) to ../vtr_flow/arch.
8282

@@ -147,12 +147,12 @@ Regression Parameters:
147147
* `--concat_circuit_list` concatenate the circuit list and pass it straight through to odin
148148
* `--generate_bench` generate input and output vectors from scratch
149149
* `--disable_simulation` disable the simulation for this task
150-
* `--disable_parallel_jobs` disable running circuit/task pairs in parralel
151-
* `--randomize` performs a dry run randomly to check the validity of the task and flow |
152-
* `--regenerate_expectation`regenerates expectation and overrides thee expected value only if there's a mismatch |
153-
* `--generate_expectation` generate the expectation and overrides the expectation file |
150+
* `--disable_parallel_jobs` disable running circuit/task pairs in parallel
151+
* `--randomize` perform a dry run randomly to check the validity of the task and flow |
152+
* `--regenerate_expectation`regenerate expectation and override the expected value only if there's a mismatch |
153+
* `--generate_expectation` generate the expectation and override the expectation file |
154154

155-
### Creating a task
155+
### Creating a Task
156156

157157
The following diagram illustrates the structure of regression tests.
158158
Each regression test needs a corresponding folder in the task directory containing the configuration file.
@@ -179,7 +179,7 @@ The task diplay name and the verilog file group should share the same title.
179179

180180
There are times where multiple configuration files are needed in a regression test due to different commands wanted or architectures.
181181
The task cmd_line_args is an example of this.
182-
If that is the case, each configuration file will still need its own folder, however these folder's should be placed in a parent folder.
182+
If that is the case, each configuration file will still need its own folder, however these folders should be placed in a parent folder.
183183

184184
```bash
185185
└── ODIN_II
@@ -205,7 +205,7 @@ If that is the case, each configuration file will still need its own folder, how
205205

206206
Suites are used to call multiple tasks at once. This is handy for regenerating results for multiple tasks.
207207
In the diagram below you can see the structure of the suite.
208-
The suite contains a configuration file that calls upon the different tasks **named task_list.conf**.
208+
The suite contains a configuration file that calls upon the different tasks named **task_list.conf**.
209209

210210
```bash
211211
└── ODIN_II
@@ -266,7 +266,7 @@ then: where N is the number of processors in the computer, and the path followin
266266

267267
> **NOTE**
268268
>
269-
> **DO NOT** run the `make sanitize` if regenerating the large test. It is probable that the computer will not have a enough ram to do so and it will take a long time. Instead run `make build`
269+
> **DO NOT** run the `make sanitize` if regenerating the large test. It is probable that the computer will not have enough ram to do so and it will take a long time. Instead run `make build`
270270
271271
For more on regenerating results, refer to the [Verify Script](./verify_script.md) section.
272272

@@ -299,19 +299,19 @@ This regression test targets cases that require a lot of ram and time.
299299

300300
### micro
301301

302-
The micro regression tests targets hards blocks and pieces that can be easily instantiated in architectures.
302+
The micro regression test targets hards blocks and pieces that can be easily instantiated in architectures.
303303

304304
### mixing_optimization
305305

306-
The mixing optimization regression tests targets mixing implementations for operations implementable in hard blocks and their soft logic counterparts that can be can be easily instantiated in architectures. The tests support extensive command line coverage, as well as provide infrastructure to enable the optimization from an .xml configuration file, require for using the optimization as a part of VTR synthesis flow.
306+
The mixing optimization regression test targets mixing implementations for operations implementable in hard blocks and their soft logic counterparts that can be can be easily instantiated in architectures. The tests support extensive command line coverage, as well as provide infrastructure to enable the optimization from an .xml configuration file, require for using the optimization as a part of VTR synthesis flow.
307307

308308
### operators
309309

310-
This regression test targets the functionality of different opertators. It checks bit size capacity and behaviour.
310+
This regression test targets the functionality of different operators. It checks bit size capacity and behaviour.
311311

312312
### syntax
313313

314-
The syntax regression tests targets syntactic behaviour. It checks that functions work cohesively together and adhere to the verilog standard.
314+
The syntax regression test targets syntactic behaviour. It checks that functions work cohesively together and adhere to the verilog standard.
315315

316316
### keywords
317317

doc/src/odin/dev_guide/verify_script.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ make sanitize
4747
```
4848

4949
A synthesis_result.json and a simulation_result.json will be generated in the task's folder.
50-
The simulation results for each benchmark are only generated if they syntehsize correctly (no exit error), thus if none of the benchmarks synthesize there will be no simulation_result.json generated.
50+
The simulation results for each benchmark are only generated if they synthesize correctly (no exit error), thus if none of the benchmarks synthesize there will be no simulation_result.json generated.
5151

5252
### Regenerating Results for a Changed Test
5353

0 commit comments

Comments
 (0)