Remove edge source accessor

Signed-off-by: Dusty DeWeese <[email protected]>

Author: HackerFoo

vpr/src/route/rr_graph.cpp

@@ -3084,12 +3084,12 @@ static void create_edge_groups(EdgeGroups* groups) {
     auto& device_ctx = g_vpr_ctx.device();
     auto& rr_nodes = device_ctx.rr_nodes;
 
-    for (size_t iedge = 0; iedge < rr_nodes.edges_size(); ++iedge) {
-        RREdgeId edge(iedge);
-        if (!device_ctx.rr_switch_inf[rr_nodes.edge_switch(edge)].configurable()) {
-            groups->add_non_config_edge(size_t(rr_nodes.edge_source_node(edge)), size_t(rr_nodes.edge_sink_node(edge)));
-        }
-    }
+    rr_nodes.for_each_edge(
+        [&](RREdgeId edge, RRNodeId src, RRNodeId sink) {
+            if (!device_ctx.rr_switch_inf[rr_nodes.edge_switch(edge)].configurable()) {
+                groups->add_non_config_edge(size_t(src), size_t(sink));
+            }
+        });
 
     groups->create_sets();
 }

vpr/src/route/rr_graph_storage.h

@@ -293,9 +293,12 @@ class t_rr_graph_storage {
         return edge_dest_node_[edge];
     }
 
-    // Get the source node for the specified edge.
-    RRNodeId edge_source_node(const RREdgeId& edge) const {
-        return edge_src_node_[edge];
+    // Call the `apply` function with the edge id, source, and sink nodes of every edge.
+    void for_each_edge(std::function<void(RREdgeId, RRNodeId, RRNodeId)> apply) const {
+        for (size_t i = 0; i < edge_dest_node_.size(); i++) {
+            RREdgeId edge(i);
+            apply(edge, edge_src_node_[edge], edge_dest_node_[edge]);
+        }
     }
 
     // Get the destination node for the iedge'th edge from specified RRNodeId.
@@ -390,11 +393,6 @@ class t_rr_graph_storage {
         return node_storage_.size();
     }
 
-    // Number of RR nodes that can be accessed.
-    size_t edges_size() const {
-        return edge_dest_node_.size();
-    }
-
     // Is the RR graph currently empty?
     bool empty() const {
         return node_storage_.empty();