Skip to content

Commit 6b597f4

Browse files
committed
[vpr][place] apply Vaughn's comments
1 parent 66c5c72 commit 6b597f4

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

vpr/src/place/place_delay_model.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ void SimpleDelayModel::read(const std::string& file) {
235235
// ToNdMatrix is a generic function for converting a Matrix capnproto
236236
// to a vtr::NdMatrix.
237237
//
238-
// The use must supply the matrix dimension (2 in this case), the source
238+
// The user must supply the matrix dimension (5 in this case), the source
239239
// capnproto type (VprFloatEntry),
240240
// target C++ type (flat), and a function to convert from the source capnproto
241241
// type to the target C++ type (ToFloat).
@@ -246,7 +246,7 @@ void SimpleDelayModel::read(const std::string& file) {
246246
}
247247

248248
void SimpleDelayModel::write(const std::string& file) const {
249-
// MallocMessageBuilder object is the generate capnproto message builder,
249+
// MallocMessageBuilder object generates capnproto message builder,
250250
// using malloc for buffer allocation.
251251
::capnp::MallocMessageBuilder builder;
252252

vpr/src/place/place_delay_model.h

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,15 @@ class SimpleDelayModel : public PlaceDelayModel {
235235
public:
236236
SimpleDelayModel() {}
237237

238+
/**
239+
* @brief Initializes the `delays_` data structure. This involves retrieving the corresponding delays for each entry from
240+
* the router lookahead and storing the minimum among them.
241+
*
242+
* @param router The router used to retrieve information from the router lookahead.
243+
* @param placer_opts Placment parameters.
244+
* @param router_opts Routing parameters.
245+
* @param longest_length The length of the longest routing track.
246+
*/
238247
void compute(
239248
RouterDelayProfiler& router,
240249
const t_placer_opts& placer_opts,
@@ -245,6 +254,9 @@ class SimpleDelayModel : public PlaceDelayModel {
245254

246255
void read(const std::string& /*file*/) override;
247256
void write(const std::string& /*file*/) const override;
257+
/**
258+
@brief Returns a reference to the array containing the placement delay matrix.
259+
*/
248260
const vtr::NdMatrix<float, 5>& delays() const {
249261
return delays_;
250262
}

0 commit comments

Comments
 (0)