Skip to content

Commit 56fbcc8

Browse files
[SQUASH ME] Moved the setup node to before checkout.
1 parent 4db9911 commit 56fbcc8

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

.github/workflows/test.yml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -73,19 +73,17 @@ jobs:
7373

7474
steps:
7575

76-
# TODO: This runnner is running on a self-hosted CPU. In order to upgrade
77-
# to v4, need to upgrade the machine to support node20.
78-
- uses: actions/checkout@v4
79-
with:
80-
submodules: 'true'
81-
8276
# Node 20 is required for recent versions of the upload artifacts action.
8377
# This may not be required once we upgrade to Ubuntu 24.04
8478
- uses: actions/setup-node@v4
8579
with:
8680
node-version: 20
8781
cache: 'npm'
8882

83+
- uses: actions/checkout@v4
84+
with:
85+
submodules: 'true'
86+
8987
- name: Setup
9088
run: stdbuf -i0 -i0 -e0 ./.github/scripts/hostsetup.sh
9189

@@ -107,8 +105,6 @@ jobs:
107105
# when the job fails). See warning here:
108106
# https://docs.github.com/en/actions/learn-github-actions/expressions#always
109107
if: ${{ !cancelled() }}
110-
# TODO: This runnner is running on a self-hosted CPU. In order to upgrade
111-
# to v4, need to upgrade the machine to support node20.
112108
uses: actions/upload-artifact@v4
113109
with:
114110
name: ${{matrix.test}}_test_results

0 commit comments

Comments
 (0)