rename comm::TelegramHeader::construct_from_data to comm::TelegramHeader::construct_from_body

Author: w0lek

vpr/src/server/gateio.cpp

@@ -167,7 +167,7 @@ GateIO::ActivityStatus GateIO::handle_client_alive_tracker(sockpp::tcp6_socket&
     if (client_alive_tracker_ptr) {
         /// handle sending echo to client
         if (client_alive_tracker_ptr->is_time_to_sent_echo()) {
-            comm::TelegramHeader echo_header = comm::TelegramHeader::construct_from_data(comm::ECHO_TELEGRAM_BODY);
+            comm::TelegramHeader echo_header = comm::TelegramHeader::construct_from_body(comm::ECHO_TELEGRAM_BODY);
             std::string message{echo_header.buffer()};
             message.append(comm::ECHO_TELEGRAM_BODY);
             try {

vpr/src/server/task.cpp

@@ -100,7 +100,7 @@ void Task::bake_response() {
     }
 
     std::string body{std::move(body_opt.value())};
-    m_telegram_header = comm::TelegramHeader::construct_from_data(body, compressor_id);
+    m_telegram_header = comm::TelegramHeader::construct_from_body(body, compressor_id);
 
     m_response_buffer.append(m_telegram_header.buffer().begin(), m_telegram_header.buffer().end());
     m_response_buffer.append(body);

vpr/src/server/telegramheader.cpp

@@ -73,7 +73,7 @@ std::string TelegramHeader::info() const {
     return ss.str();
 }
 
-comm::TelegramHeader TelegramHeader::construct_from_data(const std::string_view& body, uint8_t compressor_id) {
+comm::TelegramHeader TelegramHeader::construct_from_body(const std::string_view& body, uint8_t compressor_id) {
     uint32_t body_check_sum = ByteArray::calc_check_sum(body);
     return comm::TelegramHeader{static_cast<uint32_t>(body.size()), body_check_sum, compressor_id};
 }

vpr/src/server/telegramheader.h

@@ -62,7 +62,7 @@ class TelegramHeader {
      * @param compressor_id The ID of the compressor used for compression (default is 0, means no compressor is used).
      * @return A TelegramHeader object constructed from the provided body data.
      */
-    static comm::TelegramHeader construct_from_data(const std::string_view& body, uint8_t compressor_id = 0);
+    static comm::TelegramHeader construct_from_body(const std::string_view& body, uint8_t compressor_id = 0);
 
     /**
      * @brief Returns the total size of the TelegramHeader.

vpr/test/test_server_telegrambuffer.cpp

@@ -52,7 +52,7 @@ TEST_CASE("test_server_telegrambuffer_notFilledTelegramButWithPrependedRubish",
 
     const comm::ByteArray rubbish{"#@!"};
     const comm::ByteArray msgBody{"some message"};
-    const comm::TelegramHeader msgHeader{comm::TelegramHeader::construct_from_data(msgBody)};
+    const comm::TelegramHeader msgHeader{comm::TelegramHeader::construct_from_body(msgBody)};
 
     tBuff.append(rubbish);
     tBuff.append(msgHeader.buffer());
@@ -70,8 +70,8 @@ TEST_CASE("test_server_telegrambuffer__oneFinishedOneOpened", "[vpr]")
     const comm::ByteArray msgBody1{"message1"};
     const comm::ByteArray msgBody2{"message2"};
 
-    const comm::TelegramHeader msgHeader1{comm::TelegramHeader::construct_from_data(msgBody1)};
-    const comm::TelegramHeader msgHeader2{comm::TelegramHeader::construct_from_data(msgBody2)};
+    const comm::TelegramHeader msgHeader1{comm::TelegramHeader::construct_from_body(msgBody1)};
+    const comm::TelegramHeader msgHeader2{comm::TelegramHeader::construct_from_body(msgBody2)};
 
     comm::ByteArray t1(msgHeader1.buffer());
     t1.append(msgBody1);
@@ -98,8 +98,8 @@ TEST_CASE("test_server_telegrambuffer_twoFinished", "[vpr]")
     const comm::ByteArray msgBody1{"message1"};
     const comm::ByteArray msgBody2{"message2"};
 
-    const comm::TelegramHeader msgHeader1{comm::TelegramHeader::construct_from_data(msgBody1)};
-    const comm::TelegramHeader msgHeader2{comm::TelegramHeader::construct_from_data(msgBody2)};
+    const comm::TelegramHeader msgHeader1{comm::TelegramHeader::construct_from_body(msgBody1)};
+    const comm::TelegramHeader msgHeader2{comm::TelegramHeader::construct_from_body(msgBody2)};
 
     comm::ByteArray t1(msgHeader1.buffer());
     t1.append(msgBody1);
@@ -126,8 +126,8 @@ TEST_CASE("test_server_telegrambuffer_clear", "[vpr]")
     const comm::ByteArray msgBody1{"message1"};
     const comm::ByteArray msgBody2{"message2"};
 
-    const comm::TelegramHeader msgHeader1{comm::TelegramHeader::construct_from_data(msgBody1)};
-    const comm::TelegramHeader msgHeader2{comm::TelegramHeader::construct_from_data(msgBody2)};
+    const comm::TelegramHeader msgHeader1{comm::TelegramHeader::construct_from_body(msgBody1)};
+    const comm::TelegramHeader msgHeader2{comm::TelegramHeader::construct_from_body(msgBody2)};
 
     comm::ByteArray t1(msgHeader1.buffer());
     t1.append(msgBody1);