WIP: Fixed memory leak in assignment_alias function in netlist_creat_from_ast.cpp

j-b-1-7 · j-b-1-7 · commit 44e389d485f4 · 2019-06-28T15:16:18.000-03:00
diff --git a/ODIN_II/SRC/netlist_create_from_ast.cpp b/ODIN_II/SRC/netlist_create_from_ast.cpp
@@ -3355,10 +3355,17 @@ signal_list_t *assignment_alias(ast_node_t* assignment, char *instance_name_pref
 	}
 	else
 	{
+		ast_node_t *temp = right;
+
 		right = resolve_node(NULL, instance_name_prefix, right);
 
 		in_1 = netlist_expand_ast_of_module(right, instance_name_prefix);
 		oassert(in_1 != NULL);
+
+		if(right != temp)
+		{
+			free_whole_tree(right);
+		}
 	}
 
 	char_list_t *out_list;

Original file line number	Diff line number	Diff line change
`@@ -3355,10 +3355,17 @@ signal_list_t assignment_alias(ast_node_t assignment, char *instance_name_pref`
`3355`	`3355`	`}`
`3356`	`3356`	`else`
`3357`	`3357`	`{`
	`3358`	`+ ast_node_t *temp = right;`
	`3359`	`+`
`3358`	`3360`	`right = resolve_node(NULL, instance_name_prefix, right);`
`3359`	`3361`
`3360`	`3362`	`in_1 = netlist_expand_ast_of_module(right, instance_name_prefix);`
`3361`	`3363`	`oassert(in_1 != NULL);`
	`3364`	`+`
	`3365`	`+ if(right != temp)`
	`3366`	`+ {`
	`3367`	`+ free_whole_tree(right);`
	`3368`	`+ }`
`3362`	`3369`	`}`
`3363`	`3370`
`3364`	`3371`	`char_list_t *out_list;`