Skip to content

Commit 4300a64

Browse files
[vtr_flow] Changed Triggers for Second Run
Currently, when running the VPR stage of the vtr_flow script, if you are routing at a fixed channel width and you have "--route" or "--analysis" in the command, it will run the VPR stage twice with the exact same arguments. This is unnecessary and can make some of the runs 2x longer than they need to be. The purpose of running the VPR flow twice is that the second time would load in the temporary files produced by the first run to ensure they are the same values. It appears as though route and analysis used to be part of this check; however it is no longer being used. I checked the second run code and having the --route or --analysis flag set has no affect on the second run's arguments; so the exact same run is dispatched. I looked through all the regression tests and only found one testcase that used either of these options; which may be the reason this was never caught. This is useful for the AP flow since, to use the AP flow, we need to specify the --analytical_place flow which inherently does not perfrom routing. So we have to add --route to our arguments. I noticed that these runs took 2x longer than they should and found this issue.
1 parent 12c4600 commit 4300a64

File tree

1 file changed

+0
-2
lines changed
  • vtr_flow/scripts/python_libs/vtr

1 file changed

+0
-2
lines changed

vtr_flow/scripts/python_libs/vtr/flow.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -297,8 +297,6 @@ def run(
297297

298298
if (
299299
"write_rr_graph" in vpr_args
300-
or "analysis" in vpr_args
301-
or "route" in vpr_args
302300
or "write_router_lookahead" in vpr_args
303301
or "write_intra_cluster_router_lookahead" in vpr_args
304302
):

0 commit comments

Comments
 (0)