Skip to content

Commit 1de3eff

Browse files
committed
delete[] resultBuffer before return, which fix potential memory leak if compression/decompression wasn't succesfull
1 parent 5b440ec commit 1de3eff

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

vpr/src/server/zlibutils.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,14 @@ std::string tryCompress(const std::string& decompressed)
3030
}
3131
} while (retCode == Z_OK);
3232

33+
delete[] resultBuffer;
34+
3335
deflateEnd(&zs);
3436

3537
if (retCode != Z_STREAM_END) {
3638
return "";
3739
}
3840

39-
delete[] resultBuffer;
40-
4141
return result;
4242
}
4343

@@ -69,14 +69,14 @@ std::string tryDecompress(const std::string& compressed)
6969

7070
} while (retCode == Z_OK);
7171

72+
delete[] resultBuffer;
73+
7274
inflateEnd(&zs);
7375

7476
if (retCode != Z_STREAM_END) {
7577
return "";
7678
}
7779

78-
delete[] resultBuffer;
79-
8080
return result;
8181
}
8282

0 commit comments

Comments
 (0)