Skip to content

Commit 15cf98e

Browse files
address PR comments
1 parent 03fce64 commit 15cf98e

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

vpr/src/base/vpr_context.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,7 @@ struct ClusteringHelperContext : public Context {
345345
t_ext_pin_util_targets target_external_pin_util;
346346

347347
// During clustering, a block is related to un-clustered primitives with nets.
348-
// This relation has three types: low fanout, high fanout, and trasitive
348+
// This relation has three types: low fanout, high fanout, and transitive
349349
// high_fanout_thresholds stores the threshold for nets to a block type to be considered high fanout
350350
t_pack_high_fanout_thresholds high_fanout_thresholds;
351351

@@ -386,9 +386,10 @@ struct PlacementContext : public Context {
386386
///@brief The pl_macros array stores all the placement macros (usually carry chains).
387387
std::vector<t_pl_macro> pl_macros;
388388

389-
///@brief Stores ClusterBlockId of all movable clustered blocks.
389+
///@brief Stores ClusterBlockId of all movable clustered blocks (blocks that are not locked down to a single location)
390390
std::vector<ClusterBlockId> movable_blocks;
391391

392+
///@brief Stores ClusterBlockId of all movable clustered of each block type
392393
std::unordered_map<int, std::vector<ClusterBlockId>> movable_blocks_per_type;
393394

394395
/**

vpr/src/place/initial_placement.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ static void check_initial_placement_legality();
225225
/**
226226
* @brief Fills movable_blocks in global PlacementContext
227227
*/
228-
static void fill_movable_blocks();
228+
static void alloc_and_load_movable_blocks();
229229

230230
static void check_initial_placement_legality() {
231231
auto& cluster_ctx = g_vpr_ctx.clustering();
@@ -1154,7 +1154,7 @@ bool place_one_block(const ClusterBlockId& blk_id,
11541154
return placed_macro;
11551155
}
11561156

1157-
static void fill_movable_blocks() {
1157+
static void alloc_and_load_movable_blocks() {
11581158
auto& place_ctx = g_vpr_ctx.mutable_placement();
11591159
auto& cluster_ctx = g_vpr_ctx.clustering();
11601160
auto& device_ctx = g_vpr_ctx.device();
@@ -1225,7 +1225,7 @@ void initial_placement(const t_placer_opts& placer_opts,
12251225
//Place all blocks
12261226
place_all_blocks(placer_opts, block_scores, placer_opts.pad_loc_type, constraints_file);
12271227

1228-
fill_movable_blocks();
1228+
alloc_and_load_movable_blocks();
12291229

12301230
// ensure all blocks are placed and that NoC routing has no cycles
12311231
check_initial_placement_legality();

0 commit comments

Comments
 (0)