Skip to content

Commit ddd93e9

Browse files
nkzawarauchg
authored andcommitted
Improve babel settings (#976)
* fix babelrc settings * use only transform-es2015-modules-commonjs for transpiling emitting files
1 parent 3143e0d commit ddd93e9

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
"babel-plugin-react-require": "^3.0.0",
5151
"babel-plugin-transform-async-to-generator": "6.22.0",
5252
"babel-plugin-transform-class-properties": "6.22.0",
53+
"babel-plugin-transform-es2015-modules-commonjs": "6.22.0",
5354
"babel-plugin-transform-object-rest-spread": "6.22.0",
5455
"babel-plugin-transform-runtime": "6.22.0",
5556
"babel-preset-es2015": "6.22.0",

server/build/webpack.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@ export default async function createCompiler (dir, { dev = false, quiet = false
109109
.filter((p) => !!p)
110110

111111
const mainBabelOptions = {
112-
babelrc: true,
113112
cacheDirectory: true,
114113
sourceMaps: dev ? 'both' : false,
115114
presets: []
@@ -119,8 +118,10 @@ export default async function createCompiler (dir, { dev = false, quiet = false
119118
if (configLocation) {
120119
console.log(`> Using external babel configuration`)
121120
console.log(`> location: "${configLocation}"`)
121+
mainBabelOptions.babelrc = true
122122
} else {
123123
mainBabelOptions.presets.push(require.resolve('./babel/preset'))
124+
mainBabelOptions.babelrc = false
124125
}
125126

126127
const rules = (dev ? [{
@@ -158,14 +159,15 @@ export default async function createCompiler (dir, { dev = false, quiet = false
158159
const babelRuntimePath = require.resolve('babel-runtime/package')
159160
.replace(/[\\/]package\.json$/, '')
160161
const transpiled = babelCore.transform(content, {
161-
presets: [require.resolve('babel-preset-es2015')],
162+
babelrc: false,
162163
sourceMaps: dev ? 'both' : false,
163164
// Here we need to resolve all modules to the absolute paths.
164165
// Earlier we did it with the babel-preset.
165166
// But since we don't transpile ES2015 in the preset this is not resolving.
166167
// That's why we need to do it here.
167168
// See more: https://github.com/zeit/next.js/issues/951
168169
plugins: [
170+
[require.resolve('babel-plugin-transform-es2015-modules-commonjs')],
169171
[
170172
require.resolve('babel-plugin-module-resolver'),
171173
{

0 commit comments

Comments
 (0)