add support for changing /route/#hashes (#36079)

williamli · web-flow · commit ad1b6310deb6 · 2022-04-12T16:32:32.000Z
update with-google-analytics example to also fire events when the hash section of the URL changes.
diff --git a/examples/with-google-analytics/pages/_app.js b/examples/with-google-analytics/pages/_app.js
@@ -10,8 +10,10 @@ const App = ({ Component, pageProps }) => {
       gtag.pageview(url)
     }
     router.events.on('routeChangeComplete', handleRouteChange)
+    router.events.on('hashChangeComplete', handleRouteChange)
     return () => {
       router.events.off('routeChangeComplete', handleRouteChange)
+      router.events.off('hashChangeComplete', handleRouteChange)
     }
   }, [router.events])
 

Original file line number	Diff line number	Diff line change
`@@ -10,8 +10,10 @@ const App = ({ Component, pageProps }) => {`
`10`	`10`	`gtag.pageview(url)`
`11`	`11`	`}`
`12`	`12`	`router.events.on('routeChangeComplete', handleRouteChange)`
	`13`	`+ router.events.on('hashChangeComplete', handleRouteChange)`
`13`	`14`	`return () => {`
`14`	`15`	`router.events.off('routeChangeComplete', handleRouteChange)`
	`16`	`+ router.events.off('hashChangeComplete', handleRouteChange)`
`15`	`17`	`}`
`16`	`18`	`}, [router.events])`
`17`	`19`