Revert "fix: de-complicate earlier connection open logic"

This reverts commit d6b1b19.

Signed-off-by: varun-edachali-dbx <[email protected]>

Author: varun-edachali-dbx

src/databricks/sql/client.py

@@ -317,7 +317,9 @@ def get_protocol_version(openSessionResp):
     @property
     def open(self) -> bool:
         """Return whether the connection is open by checking if the session is open."""
-        return self.session.is_open
+        # NOTE: we have to check for the existence of session in case the __del__ is called
+        # before the session is instantiated
+        return hasattr(self, "session") and self.session.open
 
     def cursor(
         self,

src/databricks/sql/session.py

@@ -29,7 +29,7 @@ def __init__(
 
         This class handles all session-related behavior and communication with the backend.
         """
-        self.is_open = False
+        self.open = False
         self.host = server_hostname
         self.port = kwargs.get("_port", 443)
 
@@ -77,12 +77,13 @@ def __init__(
             _use_arrow_native_complex_types=_use_arrow_native_complex_types,
             **kwargs,
         )
+
         self._open_session_resp = self.thrift_backend.open_session(
             session_configuration, catalog, schema
         )
         self._session_handle = self._open_session_resp.sessionHandle
         self.protocol_version = self.get_protocol_version(self._open_session_resp)
-        self.is_open = True
+        self.open = True
         logger.info("Successfully opened session " + str(self.get_session_id_hex()))
 
     @staticmethod
@@ -121,7 +122,7 @@ def get_session_id_hex(self):
     def close(self) -> None:
         """Close the underlying session."""
         logger.info(f"Closing session {self.get_session_id_hex()}")
-        if not self.is_open:
+        if not self.open:
             logger.debug("Session appears to have been closed already")
             return
 
@@ -142,4 +143,4 @@ def close(self) -> None:
         except Exception as e:
             logger.error(f"Attempt to close session raised a local exception: {e}")
 
-        self.is_open = False
+        self.open = False