(devena-mono) Add golines pre-commit hook

The motivation here is have to think less about code formatting when
writing code, e.g. " Should I break this long list of args up? Should I
add a newline between all of these args".

The `golangci-lint` team don't want to inlcude this there for reasons[1]
so run it instead via `pre-commit`.

This is using a fork which just has one extra commit[2] until [3] is
merged upstream

[1] golangci/golangci-lint#1914
[2] segmentio/golines@dedb5a0
[3] segmentio/golines#103

Author: matthewhughes-uw

kustomize-build-dirs/main.go

@@ -27,8 +27,7 @@ Will result in the built manifests being placed at
 To avoid requiring extra broadly scoped credentials this program will empty
 any files containing secrets before running `kustomize build`. So the contents
 of any secrets will not be present in the output.
-*/
-package main
+*/package main
 
 import (
 	"errors"

kustomize-build-dirs/main_test.go

@@ -207,7 +207,10 @@ func TestFailsWhenFailingToWriteManifest(t *testing.T) {
 	buildDir := filepath.Join(outDir, manifestDir)
 	require.NoError(t, os.Mkdir(outDir, 0o700))
 	require.NoError(t, os.Mkdir(buildDir, 0o500))
-	expectedErrPrefix := fmt.Sprintf("error writing to '%s'", filepath.Join(buildDir, manifestFileName))
+	expectedErrPrefix := fmt.Sprintf(
+		"error writing to '%s'",
+		filepath.Join(buildDir, manifestFileName),
+	)
 
 	deploymentPath := filepath.Join(manifestDir, "deployment.yaml")
 	repoFiles := map[string]string{
@@ -252,8 +255,11 @@ secretGenerator:
 `
 
 	repoFiles := map[string]string{
-		"secrets.yaml":       "encryptedNonsensehere\xff\xff\n",
-		".gitattributes":     fmt.Sprintf("%s	filter=strongbox diff=strongbox\n", "secrets.yaml"),
+		"secrets.yaml": "encryptedNonsensehere\xff\xff\n",
+		".gitattributes": fmt.Sprintf(
+			"%s	filter=strongbox diff=strongbox\n",
+			"secrets.yaml",
+		),
 		"kustomization.yaml": kustomizationContent,
 	}
 
@@ -281,7 +287,12 @@ func readOutDir(t *testing.T, outDir string) map[string]string {
 	return outfileContents
 }
 
-func compareResults(t *testing.T, outDir string, expected map[string]string, got map[string]string) {
+func compareResults(
+	t *testing.T,
+	outDir string,
+	expected map[string]string,
+	got map[string]string,
+) {
 	for relPath, expectedManifest := range expected {
 		expectedPath := filepath.Join(outDir, relPath, manifestFileName)
 		gotManifest, ok := got[expectedPath]
@@ -346,7 +357,10 @@ func TestWriteMultipleManifests(t *testing.T) {
 		"second-project": secondDeploymentcontent,
 	}
 
-	require.NoError(t, kustomizeBuildDirs(outDir, false, []string{firstDeploymentPath, secondDeploymentPath}))
+	require.NoError(
+		t,
+		kustomizeBuildDirs(outDir, false, []string{firstDeploymentPath, secondDeploymentPath}),
+	)
 	compareResults(t, outDir, expectedContents, readOutDir(t, outDir))
 }
 
@@ -378,6 +392,13 @@ resources:
 		manifestsDir: expectedContent,
 	}
 
-	require.NoError(t, kustomizeBuildDirs(outDir, true, []string{filepath.Join(manifestsDir, "kustomization.yaml")}))
+	require.NoError(
+		t,
+		kustomizeBuildDirs(
+			outDir,
+			true,
+			[]string{filepath.Join(manifestsDir, "kustomization.yaml")},
+		),
+	)
 	compareResults(t, outDir, expectedContents, readOutDir(t, outDir))
 }

validate-opslevel-annotations/main_test.go

@@ -67,7 +67,14 @@ func TestFailsOnInvalidManifests(t *testing.T) {
 				expectedOut, err := os.ReadFile(filepath.Join(invalidManifestsDir, expectedOutFile))
 				require.NoErrorf(t, err, "Can't find output file for %s", entry.Name())
 				// .out files contain trailing newlines, but the error will not
-				expectedErr := strings.TrimSuffix(fmt.Sprintf("failed validating manifests from %s: %s", manifest, string(expectedOut)), "\n")
+				expectedErr := strings.TrimSuffix(
+					fmt.Sprintf(
+						"failed validating manifests from %s: %s",
+						manifest,
+						string(expectedOut),
+					),
+					"\n",
+				)
 
 				gotErr := validateOpsLevelAnnotationsForManifests([]string{manifest})
 				require.Error(t, gotErr)