fix(noImplicitAny): Fix noimplicitany compliance

Closes angular-ui/ui-router#2693

Author: christopherthielen

src/common/common.ts

@@ -617,7 +617,7 @@ function _arraysEq(a1: any[], a2: any[]) {
   return arrayTuples(a1, a2).reduce((b, t) => b && _equals(t[0], t[1]), true);
 }
 
-export type sortfn = (a,b) => number;
+export type sortfn = (a: any, b: any) => number;
 
 /**
  * Create a sort function

src/resolve/resolveContext.ts

@@ -17,7 +17,7 @@ const when = resolvePolicies.when;
 const ALL_WHENS = [when.EAGER, when.LAZY];
 const EAGER_WHENS = [when.EAGER];
 
-export const NATIVE_INJECTOR_TOKEN = "Native Injector";
+export const NATIVE_INJECTOR_TOKEN: string = "Native Injector";
 
 /**
  * Encapsulates Dependency Injection for a path of nodes

src/transition/transitionHook.ts

@@ -27,8 +27,8 @@ let defaultOptions: TransitionHookOptions = {
 export type GetResultHandler = (hook: TransitionHook) => ResultHandler;
 export type GetErrorHandler  = (hook: TransitionHook) => ErrorHandler;
 
-export type ResultHandler = (result: HookResult) => Promise<HookResult>;
-export type ErrorHandler  = (error)              => Promise<any>;
+export type ResultHandler = (result: HookResult)      => Promise<HookResult>;
+export type ErrorHandler  = (error: any)              => Promise<any>;
 
 /** @hidden */
 export class TransitionHook {
@@ -62,13 +62,13 @@ export class TransitionHook {
    * These GetErrorHandler(s) are used by [[invokeHook]] below
    * Each HookType chooses a GetErrorHandler (See: [[TransitionService._defineCoreEvents]])
    */
-  static LOG_ERROR: GetErrorHandler = (hook: TransitionHook) => (error) =>
+  static LOG_ERROR: GetErrorHandler = (hook: TransitionHook) => (error: any) =>
       hook.logError(error);
 
-  static REJECT_ERROR: GetErrorHandler = (hook: TransitionHook) => (error) =>
+  static REJECT_ERROR: GetErrorHandler = (hook: TransitionHook) => (error: any) =>
       silentRejection(error);
 
-  static THROW_ERROR: GetErrorHandler = (hook: TransitionHook) => (error) => {
+  static THROW_ERROR: GetErrorHandler = (hook: TransitionHook) => (error: any) => {
     throw error;
   };
 

tslint.json

@@ -35,7 +35,7 @@
     "no-trailing-comma": true,
     "no-trailing-whitespace": false,
     "no-unreachable": true,
-    "no-unused-expression": true,
+    "no-unused-expression": [true, "allow-fast-null-checks"],
     "no-unused-variable": true,
     "no-use-before-declare": true,
     "no-var-keyword": true,