Skip to content

[Suggestion] document.getElementById is not correctly typed in TypeScript #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Judekeyser opened this issue Jan 22, 2025 · 1 comment · Fixed by #65
Closed

[Suggestion] document.getElementById is not correctly typed in TypeScript #63

Judekeyser opened this issue Jan 22, 2025 · 1 comment · Fixed by #65
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Judekeyser
Copy link

In TypeScript, getElementById returns a HTMLElement, while the standard mandates it to return a Element in order to account for more general situations like SVGElement and alike.

This change seems to be refused by TypeScript, for many years now:

@uhyo
Copy link
Owner

uhyo commented Jan 23, 2025

Thank you for suggestion. I think I'd accept a fix.

Even if we only consider ordinary HTML documents, they could include SVG elements that are not HTMLElements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
2 participants