Skip to content

Commit ac98159

Browse files
committed
fix bug with github not failing correctly
1 parent e26101e commit ac98159

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

index.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ class PkgPyFuncs {
2424
if ( !config ) {
2525
this.error("No serverless-package-python-functions configuration detected. Please see documentation")
2626
}
27-
2827
this.requirementsFile = config.requirementsFile || 'requirements.txt'
2928
config.buildDir ? this.buildDir = config.buildDir : this.error("No buildDir configuration specified")
3029
this.globalRequirements = config.globalRequirements || []
@@ -35,7 +34,6 @@ class PkgPyFuncs {
3534
this.containerName = config.containerName || 'serverless-package-python-functions'
3635
this.mountSSH = config.mountSSH || false
3736
this.abortOnPackagingErrors = config.abortOnPackagingErrors || false
38-
3937
this.dockerServicePath = '/var/task'
4038
}
4139

@@ -122,7 +120,8 @@ class PkgPyFuncs {
122120
if (this.abortOnPackagingErrors){
123121
const countErrorNewLines = errorText.split('\n').length
124122

125-
if(countErrorNewLines < 2 && errorText.toLowerCase().includes('git clone')){
123+
124+
if(!errorText.includes("ERROR:") && countErrorNewLines < 2 && errorText.toLowerCase().includes('git clone')){
126125
// Ignore false positive due to pip git clone printing to stderr
127126
} else if(errorText.toLowerCase().includes('warning') && !errorText.toLowerCase().includes('error')){
128127
// Ignore warnings

0 commit comments

Comments
 (0)