-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Tests: Reduce the giant number of naming-convention tests #9691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Right now, what we have is basically 16,000 integration tests! Here are the counts:
Would it be appropriate to split up the tests into two parts:
By doing that, we wouldn't have to worry about testing every combination of selector multiplied by every combination of naming convention. |
It seems pretty bonkers to me that it takes 30 seconds to run 763 non-type-aware tests. Either there is something else at play or those windows test boxes are infinitesimally small boxes. |
Suggestion
The auto-generated
naming-convention
tests are by far the slowest part ofpackages/eslint-plugin
. We've done work in the past to speed them up:...but they still take >10 seconds for some files on the Windows CI jobs. Example from https://github.com/typescript-eslint/typescript-eslint/actions/runs/10184575611/job/28172431302?pr=9165:
Let's see if we can shrink those tests down to be less explosively many.
💖
The text was updated successfully, but these errors were encountered: