apply review

Author: yeonjuan

Diff for: packages/eslint-plugin/src/rules/consistent-type-assertions.ts

@@ -35,6 +35,10 @@ type OptUnion =
     };
 export type Options = readonly [OptUnion];
 
+type AsExpressionOrTypeAssertion =
+  | TSESTree.TSAsExpression
+  | TSESTree.TSTypeAssertion;
+
 export default createRule<Options, MessageIds>({
   name: 'consistent-type-assertions',
   meta: {
@@ -122,7 +126,7 @@ export default createRule<Options, MessageIds>({
     }
 
     function reportIncorrectAssertionType(
-      node: TSESTree.TSAsExpression | TSESTree.TSTypeAssertion,
+      node: AsExpressionOrTypeAssertion,
     ): void {
       const messageId = options.assertionStyle;
 
@@ -209,7 +213,7 @@ export default createRule<Options, MessageIds>({
     }
 
     function getSuggestions(
-      node: TSESTree.TSAsExpression | TSESTree.TSTypeAssertion,
+      node: AsExpressionOrTypeAssertion,
       annotationMessageId: MessageIds,
       satisfiesMessageId: MessageIds,
     ): TSESLint.ReportSuggestionArray<MessageIds> {
@@ -251,9 +255,7 @@ export default createRule<Options, MessageIds>({
       return suggestions;
     }
 
-    function isAsParameter(
-      node: TSESTree.TSAsExpression | TSESTree.TSTypeAssertion,
-    ): boolean {
+    function isAsParameter(node: AsExpressionOrTypeAssertion): boolean {
       return (
         node.parent.type === AST_NODE_TYPES.NewExpression ||
         node.parent.type === AST_NODE_TYPES.CallExpression ||
@@ -266,7 +268,7 @@ export default createRule<Options, MessageIds>({
     }
 
     function checkExpressionForObjectAssertion(
-      node: TSESTree.TSAsExpression | TSESTree.TSTypeAssertion,
+      node: AsExpressionOrTypeAssertion,
     ): void {
       if (
         options.assertionStyle === 'never' ||
@@ -278,14 +280,7 @@ export default createRule<Options, MessageIds>({
 
       if (
         options.objectLiteralTypeAssertions === 'allow-as-parameter' &&
-        (node.parent.type === AST_NODE_TYPES.NewExpression ||
-          node.parent.type === AST_NODE_TYPES.CallExpression ||
-          node.parent.type === AST_NODE_TYPES.ThrowStatement ||
-          node.parent.type === AST_NODE_TYPES.AssignmentPattern ||
-          node.parent.type === AST_NODE_TYPES.JSXExpressionContainer ||
-          (node.parent.type === AST_NODE_TYPES.TemplateLiteral &&
-            node.parent.parent.type ===
-              AST_NODE_TYPES.TaggedTemplateExpression))
+        isAsParameter(node)
       ) {
         return;
       }
@@ -306,7 +301,7 @@ export default createRule<Options, MessageIds>({
     }
 
     function checkExpressionForArrayAssertion(
-      node: TSESTree.TSAsExpression | TSESTree.TSTypeAssertion,
+      node: AsExpressionOrTypeAssertion,
     ): void {
       if (
         options.assertionStyle === 'never' ||

Diff for: packages/eslint-plugin/tests/rules/consistent-type-assertions.test.ts

@@ -226,6 +226,25 @@ function foo() {
         },
       ],
     },
+    {
+      code: 'new Print([5] as Foo);',
+      options: [
+        {
+          arrayLiteralTypeAssertions: 'allow-as-parameter',
+          assertionStyle: 'as',
+        },
+      ],
+    },
+    {
+      code: 'const bar = <Foo style={[5] as Bar} />;',
+      languageOptions: { parserOptions: { ecmaFeatures: { jsx: true } } },
+      options: [
+        {
+          arrayLiteralTypeAssertions: 'allow-as-parameter',
+          assertionStyle: 'as',
+        },
+      ],
+    },
     {
       code: 'print(<Foo>[5]);',
       options: [
@@ -284,6 +303,15 @@ function foo() {
         },
       ],
     },
+    {
+      code: 'new Print(<Foo>[5]);',
+      options: [
+        {
+          arrayLiteralTypeAssertions: 'allow-as-parameter',
+          assertionStyle: 'angle-bracket',
+        },
+      ],
+    },
     { code: 'const x = <const>[1];', options: [{ assertionStyle: 'never' }] },
     { code: 'const x = [1] as const;', options: [{ assertionStyle: 'never' }] },
     {
@@ -1037,6 +1065,27 @@ function foo() {
         },
       ],
     },
+    {
+      code: 'const foo = () => [5] as Foo',
+      errors: [
+        {
+          messageId: 'unexpectedArrayTypeAssertion',
+          suggestions: [
+            {
+              data: { cast: 'Foo' },
+              messageId: 'replaceArrayTypeAssertionWithSatisfies',
+              output: 'const foo = () => [5] satisfies Foo',
+            },
+          ],
+        },
+      ],
+      options: [
+        {
+          arrayLiteralTypeAssertions: 'allow-as-parameter',
+          assertionStyle: 'as',
+        },
+      ],
+    },
     {
       code: 'new print(<Foo>[5]);',
       errors: [
@@ -1129,5 +1178,31 @@ function foo() {
         },
       ],
     },
+    {
+      code: 'const foo = <Foo>[5];',
+      errors: [
+        {
+          messageId: 'unexpectedArrayTypeAssertion',
+          suggestions: [
+            {
+              data: { cast: 'Foo' },
+              messageId: 'replaceArrayTypeAssertionWithAnnotation',
+              output: 'const foo: Foo = [5];',
+            },
+            {
+              data: { cast: 'Foo' },
+              messageId: 'replaceArrayTypeAssertionWithSatisfies',
+              output: 'const foo = [5] satisfies Foo;',
+            },
+          ],
+        },
+      ],
+      options: [
+        {
+          arrayLiteralTypeAssertions: 'allow-as-parameter',
+          assertionStyle: 'angle-bracket',
+        },
+      ],
+    },
   ],
 });