Skip to content

Commit 4d2ce3b

Browse files
fix(eslint-plugin): [prefer-readonly] disable checking accessors (#8300)
* Disable checking accessors for prefer-readonly * Granular accessor tests * Update packages/eslint-plugin/src/rules/prefer-readonly.ts * fix: formatting and || for isModifierFlagSet suggestion --------- Co-authored-by: Josh Goldberg ✨ <[email protected]>
1 parent e95d719 commit 4d2ce3b

File tree

2 files changed

+24
-1
lines changed

2 files changed

+24
-1
lines changed

Diff for: packages/eslint-plugin/src/rules/prefer-readonly.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,10 @@ class ClassScope {
299299
tsutils.isModifierFlagSet(node, ts.ModifierFlags.Private) ||
300300
node.name.kind === ts.SyntaxKind.PrivateIdentifier
301301
) ||
302-
tsutils.isModifierFlagSet(node, ts.ModifierFlags.Readonly) ||
302+
tsutils.isModifierFlagSet(
303+
node,
304+
ts.ModifierFlags.Accessor | ts.ModifierFlags.Readonly,
305+
) ||
303306
ts.isComputedPropertyName(node.name)
304307
) {
305308
return;

Diff for: packages/eslint-plugin/tests/rules/prefer-readonly.test.ts

+20
Original file line numberDiff line numberDiff line change
@@ -717,6 +717,26 @@ class Foo {
717717
}
718718
}
719719
`,
720+
`
721+
class TestStaticPrivateAccessor {
722+
private static accessor staticAcc = 1;
723+
}
724+
`,
725+
`
726+
class TestStaticPrivateFieldAccessor {
727+
static accessor #staticAcc = 1;
728+
}
729+
`,
730+
`
731+
class TestPrivateAccessor {
732+
private accessor acc = 3;
733+
}
734+
`,
735+
`
736+
class TestPrivateFieldAccessor {
737+
accessor #acc = 3;
738+
}
739+
`,
720740
],
721741
invalid: [
722742
{

0 commit comments

Comments
 (0)