Skip to content

Commit 4190828

Browse files
committed
chore(eslint-plugin): [no-unused-vars] avoid extra calculation before continue
1 parent dd71460 commit 4190828

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

Diff for: packages/eslint-plugin/src/rules/no-unused-vars.ts

+10-10
Original file line numberDiff line numberDiff line change
@@ -579,16 +579,6 @@ export default createRule<Options, MessageIds>({
579579
for (const unusedVar of unusedVars) {
580580
// Report the first declaration.
581581
if (unusedVar.defs.length > 0) {
582-
const writeReferences = unusedVar.references.filter(
583-
ref =>
584-
ref.isWrite() &&
585-
ref.from.variableScope === unusedVar.scope.variableScope,
586-
);
587-
588-
const id = writeReferences.length
589-
? writeReferences[writeReferences.length - 1].identifier
590-
: unusedVar.identifiers[0];
591-
592582
const usedOnlyAsType = unusedVar.references.some(ref =>
593583
referenceContainsTypeQuery(ref.identifier),
594584
);
@@ -602,6 +592,16 @@ export default createRule<Options, MessageIds>({
602592
continue;
603593
}
604594

595+
const writeReferences = unusedVar.references.filter(
596+
ref =>
597+
ref.isWrite() &&
598+
ref.from.variableScope === unusedVar.scope.variableScope,
599+
);
600+
601+
const id = writeReferences.length
602+
? writeReferences[writeReferences.length - 1].identifier
603+
: unusedVar.identifiers[0];
604+
605605
const messageId = usedOnlyAsType ? 'usedOnlyAsType' : 'unusedVar';
606606

607607
const { start } = id.loc;

0 commit comments

Comments
 (0)