Skip to content

Adjust for using nullish coalescing and navigation #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Nov 15, 2019 · 1 comment
Closed

Adjust for using nullish coalescing and navigation #270

JoshuaKGoldberg opened this issue Nov 15, 2019 · 1 comment
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send in a PR to resolve this! ✨ type: cleanup Code smells, incorrect tests, build systems, or other internal shenanigans

Comments

@JoshuaKGoldberg
Copy link
Member

Overview

Following #269, now that we're on TypeScript 3.7, we can replace && and !== undefined checks with ?? and ?.. Hooray!

Filing this to keep track of a nice code cleanup task.
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send in a PR to resolve this! ✨ type: cleanup Code smells, incorrect tests, build systems, or other internal shenanigans labels Nov 15, 2019
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Nov 15, 2019
@JoshuaKGoldberg
Copy link
Member Author

I scanned through and found almost no instances where these would be useful. Ah well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send in a PR to resolve this! ✨ type: cleanup Code smells, incorrect tests, build systems, or other internal shenanigans
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg