Skip to content

Missing option converters member-access / explicit-member-accessibility #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshuaKGoldberg opened this issue Aug 6, 2019 · 0 comments · Fixed by #231
Closed

Missing option converters member-access / explicit-member-accessibility #139

JoshuaKGoldberg opened this issue Aug 6, 2019 · 0 comments · Fixed by #231
Labels
area: incorrect converter Rule converter with incomplete, incorrect, or invalid rule names and/or arguments good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨

Comments

@JoshuaKGoldberg
Copy link
Member

🐛 Bug Report

  • tslint-to-eslint-config version: 0.2.2
  • ESLint version: N/A
  • Node version: N/A

Actual Behavior

Right now, the converter from TSLint's member-access rule to ESLint's @typescript-eslint/explicit-member-visibility does not read the TSLint rule options. It assumes there are no configuration rule options for the rule.

Expected Behavior

There are actually several options on both the TSLint and ESLint side:

The rule converter should read in those options from the TSLint rule and create the equivalent configuration (if possible) in the output ESLint settings.

@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨ type: bug Something isn't working area: incorrect converter Rule converter with incomplete, incorrect, or invalid rule names and/or arguments labels Aug 6, 2019
@JoshuaKGoldberg JoshuaKGoldberg removed the type: bug Something isn't working label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: incorrect converter Rule converter with incomplete, incorrect, or invalid rule names and/or arguments good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant