Skip to content

CI checks aren't enforcing Prettier #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue May 27, 2021 · 1 comment · Fixed by #1163
Closed

CI checks aren't enforcing Prettier #1101

JoshuaKGoldberg opened this issue May 27, 2021 · 1 comment · Fixed by #1163
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send in a PR to resolve this! ✨ tooling Things that touch how the repository is built, published, etc. type: bug Something isn't working

Comments

@JoshuaKGoldberg
Copy link
Member

Overview

Sibling to #1100: this was never checked because the CircleCI config doesn't enforce that prettier --list-different has no entries.

Actual Behavior

You can git commit --no-verify and git push non-Prettier-ok code.

Expected Behavior

🙅
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working status: accepting prs Please, send in a PR to resolve this! ✨ tooling Things that touch how the repository is built, published, etc. labels May 27, 2021
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this May 27, 2021
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue May 27, 2021
Merged
2 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jul 3, 2021
Merged
1 task
@JoshuaKGoldberg
Copy link
Member Author

Wait, #1127 didn't enforce this in CI.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jul 7, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send in a PR to resolve this! ✨ tooling Things that touch how the repository is built, published, etc. type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added --check to Prettier in CI typescript-eslint/tslint-to-eslint-config
1 participant
@JoshuaKGoldberg