Removed plugin prefixes from converter and merger paths (#1203)

* Removed plugin prefixes from conveter and merger paths

* Moved up ngrx- and rxjs-

* Cleaned up rxjs converters

* A couple cleanups

* Fix add too

* Missing rxjs-no-unsafe-takeuntil ruleName

* Corrected ngrx-no-duplicate-action-types.test.ts

* Added prefer-inline-decorator.test.ts

* Ugh one more

Author: Josh Goldberg

src/converters/lintConfigs/rules/ruleConverters.ts

@@ -1,4 +1,4 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
 export const convertAngularWhitespace: RuleConverter = () => {
     return {};

src/converters/lintConfigs/rules/ruleConverters/codelyzer/angular-whitespace.ts renamed to src/converters/lintConfigs/rules/ruleConverters/angular-whitespace.ts

@@ -1,4 +1,4 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
 export const convertCognitiveComplexity: RuleConverter = (tslintRule) => {
     return {

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-sonarjs/cognitive-complexity.ts renamed to src/converters/lintConfigs/rules/ruleConverters/cognitive-complexity.ts

@@ -1,4 +1,4 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
 export const convertComponentClassSuffix: RuleConverter = (tslintRule) => {
     return {

src/converters/lintConfigs/rules/ruleConverters/codelyzer/component-class-suffix.ts renamed to src/converters/lintConfigs/rules/ruleConverters/component-class-suffix.ts

@@ -1,4 +1,4 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
 export const convertComponentMaxInlineDeclarations: RuleConverter = (tslintRule) => {
     return {

src/converters/lintConfigs/rules/ruleConverters/codelyzer/component-max-inline-declarations.ts renamed to src/converters/lintConfigs/rules/ruleConverters/component-max-inline-declarations.ts

@@ -1,4 +1,4 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
 export const convertComponentSelector: RuleConverter = (tslintRule) => {
     return {

src/converters/lintConfigs/rules/ruleConverters/codelyzer/component-selector.ts renamed to src/converters/lintConfigs/rules/ruleConverters/component-selector.ts

@@ -1,4 +1,4 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
 export const convertConsecutiveOverloads: RuleConverter = () => {
     return {

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-sonarjs/consecutive-overloads.ts renamed to src/converters/lintConfigs/rules/ruleConverters/consecutive-overloads.ts

@@ -1,4 +1,4 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
 export const convertContextualDecorator: RuleConverter = () => {
     return {

src/converters/lintConfigs/rules/ruleConverters/codelyzer/contextual-decorator.ts renamed to src/converters/lintConfigs/rules/ruleConverters/contextual-decorator.ts

@@ -1,4 +1,4 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
 export const convertContextualLifecycle: RuleConverter = () => {
     return {

src/converters/lintConfigs/rules/ruleConverters/codelyzer/contextual-lifecycle.ts renamed to src/converters/lintConfigs/rules/ruleConverters/contextual-lifecycle.ts

@@ -1,4 +1,4 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
 export const convertDirectiveClassSuffix: RuleConverter = (tslintRule) => {
     return {

src/converters/lintConfigs/rules/ruleConverters/codelyzer/directive-class-suffix.ts renamed to src/converters/lintConfigs/rules/ruleConverters/directive-class-suffix.ts

@@ -1,4 +1,4 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
 export const convertDirectiveSelector: RuleConverter = (tslintRule) => {
     return {

src/converters/lintConfigs/rules/ruleConverters/codelyzer/directive-selector.ts renamed to src/converters/lintConfigs/rules/ruleConverters/directive-selector.ts

@@ -1,4 +1,4 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
 export const convertImportDestructuringSpacing: RuleConverter = () => {
     return {};

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/add.ts

@@ -1,4 +1,4 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
 export const convertJsxBanProps: RuleConverter = (tslintRule) => {
     return {

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/deep-operators.ts

@@ -1,4 +1,4 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
 export const convertJsxBooleanValue: RuleConverter = (tslintRule) => {
     return {

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-add.ts

@@ -1,4 +1,4 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
 export const convertJsxCurlySpacing: RuleConverter = (tslintRule) => {
     return {

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-deep-operators.ts

@@ -1,4 +1,4 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
 export const convertJsxEqualsSpacing: RuleConverter = (tslintRule) => {
     return {

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-operator.ts

@@ -1,4 +1,4 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
 export const convertJsxKey: RuleConverter = () => {
     return {

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-patched.ts

@@ -1,4 +1,4 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
 export const convertJsxNoBind: RuleConverter = () => {
     return {

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-unsafe-scope.ts

@@ -1,4 +1,4 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
 export const convertJsxNoLambda: RuleConverter = () => {
     return {

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-unused-add.ts

@@ -1,4 +1,4 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
 export const convertJsxSelfClose: RuleConverter = () => {
     return {

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-wholesale.ts

@@ -1,4 +1,4 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
 export const convertJsxSpaceBeforeTrailingSlash: RuleConverter = () => {
     return {

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/prefer-add.ts

@@ -1,4 +1,4 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
 export const convertJsxWrapMultiline: RuleConverter = () => {
     return {

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/add.test.ts

@@ -1,4 +1,4 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
 export const convertMaxSwitchCases: RuleConverter = (tslintRule) => {
     return {

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/deep-operators.test.ts

@@ -1,6 +1,6 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
-export const convertActionHygiene: RuleConverter = () => {
+export const convertNgrxActionHygiene: RuleConverter = () => {
     return {
         rules: [
             {

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/no-deep-operators.test.ts

@@ -1,6 +1,6 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
-export const convertAvoidDispatchingMultipleActionsSequentially: RuleConverter = () => {
+export const convertNgrxAvoidDispatchingMultipleActionsSequentially: RuleConverter = () => {
     return {
         rules: [
             {

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/no-operator.test.ts

@@ -1,6 +1,6 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
-export const convertEffectCreatorAndDecorator: RuleConverter = () => {
+export const convertNgrxEffectCreatorAndDecorator: RuleConverter = () => {
     return {
         rules: [
             {

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/no-unsafe-scope.test.ts

@@ -1,6 +1,6 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
-export const convertNoDispatchInEffects: RuleConverter = () => {
+export const convertNgrxNoDispatchInEffects: RuleConverter = () => {
     return {
         rules: [
             {

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/no-unused-add.test.ts

@@ -0,0 +1,7 @@
+import { RuleConverter } from "../ruleConverter";
+
+export const convertNgrxNoDuplicateActionTypes: RuleConverter = () => {
+    return {
+        rules: [],
+    };
+};

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/no-wholesale.test.ts

@@ -1,6 +1,6 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
-export const convertNoEffectDecorator: RuleConverter = () => {
+export const convertNgrxNoEffectDecorator: RuleConverter = () => {
     return {
         rules: [
             {

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/prefer-add.test.ts

@@ -1,6 +1,6 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
-export const convertNoEffectsInProviders: RuleConverter = () => {
+export const convertNgrxNoEffectsInProviders: RuleConverter = () => {
     return {
         rules: [
             {

src/converters/lintConfigs/rules/ruleConverters/codelyzer/import-destructuring-spacing.ts renamed to src/converters/lintConfigs/rules/ruleConverters/import-destructuring-spacing.ts

@@ -1,6 +1,6 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
-export const convertNoMultipleActionsInEffects: RuleConverter = () => {
+export const convertNgrxNoMultipleActionsInEffects: RuleConverter = () => {
     return {
         rules: [
             {

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-react/jsx-ban-props.ts renamed to src/converters/lintConfigs/rules/ruleConverters/jsx-ban-props.ts

@@ -1,6 +1,6 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
-export const convertNoReducerInKeyNames: RuleConverter = () => {
+export const convertNgrxNoReducerInKeyNames: RuleConverter = () => {
     return {
         rules: [
             {

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-react/jsx-boolean-value.ts renamed to src/converters/lintConfigs/rules/ruleConverters/jsx-boolean-value.ts

@@ -1,6 +1,6 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
-export const convertNoTypedStore: RuleConverter = () => {
+export const convertNgrxNoTypedStore: RuleConverter = () => {
     return {
         rules: [
             {

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-react/jsx-curly-spacing.ts renamed to src/converters/lintConfigs/rules/ruleConverters/jsx-curly-spacing.ts

@@ -1,6 +1,6 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
-export const convertOnReducerExplicitReturnType: RuleConverter = () => {
+export const convertNgrxOnReducerExplicitReturnType: RuleConverter = () => {
     return {
         rules: [
             {

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-react/jsx-equals-spacing.ts renamed to src/converters/lintConfigs/rules/ruleConverters/jsx-equals-spacing.ts

@@ -1,6 +1,6 @@
-import { RuleConverter } from "../../ruleConverter";
+import { RuleConverter } from "../ruleConverter";
 
-export const convertSelectorForSelect: RuleConverter = () => {
+export const convertNgrxSelectorForSelect: RuleConverter = () => {
     return {
         rules: [
             {