Skip to content

Commit bec4a01

Browse files
committed
Merge branch 'master' into add-resize-observer
2 parents 1601cca + 7345e8d commit bec4a01

20 files changed

+764
-631
lines changed

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,7 @@ __pycache__/
281281
generated/
282282
lib/
283283
inputfiles/browser.webidl.json
284-
.vscode
284+
.vscode/*
285+
!.vscode/launch.template.json
285286
package-lock.json
286287
yarn.lock

README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,9 @@ The common steps to send a pull request are:
5353

5454
### What are the TypeScript team's heuristics for PRs to the DOM APIs
5555

56-
Changes to this repo can have pretty drastic ecosystem effects, because these types are included by default in TypeScript.
56+
Changes to this repo can have pretty drastic ecosystem effects, because these types are included by default in TypeScript.
5757
Due to this, we tend to be quite conservative with our approach to introducing changes.
58-
To give you a sense of whether we will accept changes, you can use these heuristics to know up-front if we'll be open to merging.
58+
To give you a sense of whether we will accept changes, you can use these heuristics to know up-front if we'll be open to merging.
5959

6060
#### Fixes
6161

@@ -71,9 +71,9 @@ To give you a sense of whether we will accept changes, you can use these heurist
7171
> For example, adding a new spec or subsection via a new or updated IDL file
7272
7373
- Does the new objects or fields show up in [mdn/browser-compat-data](https://github.com/mdn/browser-compat-data)? If not, it's likely too soon.
74-
- Is the IDL source from WHATWG?
74+
- Is the IDL source from WHATWG?
7575
- Are the additions available in at least two of Firefox, Safari and Chromium?
76-
- Is the IDL source from W3C?
76+
- Is the IDL source from W3C?
7777
- What stage of the [W3C process](https://en.wikipedia.org/wiki/World_Wide_Web_Consortium#Specification_maturation) is the proposal for these changes: We aim for Proposed recommendation, but can accept Candidate recommendation for stable looking proposals.
7878
- If it's at Working draft the additions available in all three of Firefox, Safari and Chromium
7979
- Could any types added at the global scope have naming conflicts?
@@ -103,3 +103,4 @@ To give you a sense of whether we will accept changes, you can use these heurist
103103
- `overridingTypes.json`: types that are defined in the spec file but has a better or more up-to-date definitions in the json files.
104104
- `removedTypes.json`: types that are defined in the spec file but should be removed.
105105
- `comments.json`: comment strings to be embedded in the generated .js files.
106+
- `deprecatedMessage.json`: the reason why one type is deprecated. The reason why it is a separate file rather than merge in comment.json is mdn/apiDescriptions.json would also possibly be deprecated.

0 commit comments

Comments
 (0)