Skip to content

Commit 9e13665

Browse files
Andaristsaschanaz
Andarist
and
saschanaz
authored
Disallow clearing timers without no argument at all (microsoft#1330)
Co-authored-by: saschanaz <[email protected]>
1 parent cf49d9e commit 9e13665

5 files changed

+48
-16
lines changed

‎baselines/dom.generated.d.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16670,8 +16670,8 @@ interface WindowOrWorkerGlobalScope {
1667016670
readonly performance: Performance;
1667116671
atob(data: string): string;
1667216672
btoa(data: string): string;
16673-
clearInterval(id?: number): void;
16674-
clearTimeout(id?: number): void;
16673+
clearInterval(id: number | undefined): void;
16674+
clearTimeout(id: number | undefined): void;
1667516675
createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
1667616676
createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
1667716677
fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;
@@ -17978,8 +17978,8 @@ declare var origin: string;
1797817978
declare var performance: Performance;
1797917979
declare function atob(data: string): string;
1798017980
declare function btoa(data: string): string;
17981-
declare function clearInterval(id?: number): void;
17982-
declare function clearTimeout(id?: number): void;
17981+
declare function clearInterval(id: number | undefined): void;
17982+
declare function clearTimeout(id: number | undefined): void;
1798317983
declare function createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
1798417984
declare function createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
1798517985
declare function fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;

‎baselines/serviceworker.generated.d.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5116,8 +5116,8 @@ interface WindowOrWorkerGlobalScope {
51165116
readonly performance: Performance;
51175117
atob(data: string): string;
51185118
btoa(data: string): string;
5119-
clearInterval(id?: number): void;
5120-
clearTimeout(id?: number): void;
5119+
clearInterval(id: number | undefined): void;
5120+
clearTimeout(id: number | undefined): void;
51215121
createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
51225122
createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
51235123
fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;
@@ -5488,8 +5488,8 @@ declare var origin: string;
54885488
declare var performance: Performance;
54895489
declare function atob(data: string): string;
54905490
declare function btoa(data: string): string;
5491-
declare function clearInterval(id?: number): void;
5492-
declare function clearTimeout(id?: number): void;
5491+
declare function clearInterval(id: number | undefined): void;
5492+
declare function clearTimeout(id: number | undefined): void;
54935493
declare function createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
54945494
declare function createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
54955495
declare function fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;

‎baselines/sharedworker.generated.d.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4969,8 +4969,8 @@ interface WindowOrWorkerGlobalScope {
49694969
readonly performance: Performance;
49704970
atob(data: string): string;
49714971
btoa(data: string): string;
4972-
clearInterval(id?: number): void;
4973-
clearTimeout(id?: number): void;
4972+
clearInterval(id: number | undefined): void;
4973+
clearTimeout(id: number | undefined): void;
49744974
createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
49754975
createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
49764976
fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;
@@ -5502,8 +5502,8 @@ declare var origin: string;
55025502
declare var performance: Performance;
55035503
declare function atob(data: string): string;
55045504
declare function btoa(data: string): string;
5505-
declare function clearInterval(id?: number): void;
5506-
declare function clearTimeout(id?: number): void;
5505+
declare function clearInterval(id: number | undefined): void;
5506+
declare function clearTimeout(id: number | undefined): void;
55075507
declare function createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
55085508
declare function createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
55095509
declare function fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;

‎baselines/webworker.generated.d.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5250,8 +5250,8 @@ interface WindowOrWorkerGlobalScope {
52505250
readonly performance: Performance;
52515251
atob(data: string): string;
52525252
btoa(data: string): string;
5253-
clearInterval(id?: number): void;
5254-
clearTimeout(id?: number): void;
5253+
clearInterval(id: number | undefined): void;
5254+
clearTimeout(id: number | undefined): void;
52555255
createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
52565256
createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
52575257
fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;
@@ -5791,8 +5791,8 @@ declare var origin: string;
57915791
declare var performance: Performance;
57925792
declare function atob(data: string): string;
57935793
declare function btoa(data: string): string;
5794-
declare function clearInterval(id?: number): void;
5795-
declare function clearTimeout(id?: number): void;
5794+
declare function clearInterval(id: number | undefined): void;
5795+
declare function clearTimeout(id: number | undefined): void;
57965796
declare function createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
57975797
declare function createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
57985798
declare function fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;

‎inputfiles/overridingTypes.jsonc

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,38 @@
218218
}
219219
}
220220
}
221+
},
222+
"WindowOrWorkerGlobalScope": {
223+
"methods": {
224+
"method": {
225+
"clearInterval": {
226+
"signature": {
227+
"0": {
228+
"param": [
229+
{
230+
"name": "id",
231+
"optional": false,
232+
"additionalTypes": ["undefined"]
233+
}
234+
]
235+
}
236+
}
237+
},
238+
"clearTimeout": {
239+
"signature": {
240+
"0": {
241+
"param": [
242+
{
243+
"name": "id",
244+
"optional": false,
245+
"additionalTypes": ["undefined"]
246+
}
247+
]
248+
}
249+
}
250+
}
251+
}
252+
}
221253
}
222254
}
223255
},

0 commit comments

Comments
 (0)