Skip to content

Commit 3de3955

Browse files
committed
cr feedback
1 parent 238509d commit 3de3955

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ To build the tool, simply clone the repo, and run `build.cmd` in command line or
1010
- `JS.fs`: handles the emitting of the `domWeb.js` and `domWindows.js`
1111

1212
## Contribution Guide
13-
The `dom.generated.d.ts` and `webworker.generated.d.ts` files that are used in TypeScript repo `master` branch are used as baselines.
14-
For each pull request, we will try run the script and compare the generated files with the baseline files.
15-
So to make the tests passed, please update the baseline and the code at the same pull request.
13+
The `dom.generated.d.ts` and `webworker.generated.d.ts` files in the TypeScript repo are used as baselines.
14+
For each pull request, we will run the script and compare the generated files with the baseline files.
15+
In order to make the tests pass, please update the baseline as well in any pull requests.
1616

1717
For common changes, it is sufficient to change the json files.
1818
There are three json files that are used to alter the file generation: `addedTypes.json`, `overridingTypes.json` and `removedTypes.json`.

0 commit comments

Comments
 (0)