Move opacity to trace_patch

Timoté Vaucher · Timoté Vaucher · commit 64b93a1d5541 · 2020-03-26T12:55:15.000+01:00
diff --git a/packages/python/plotly/plotly/express/_chart_types.py b/packages/python/plotly/plotly/express/_chart_types.py
@@ -1089,7 +1089,9 @@ def density_mapbox(
     the color of the region around the corresponding point on the map
     """
     return make_figure(
-        args=locals(), constructor=go.Densitymapbox, trace_patch=dict(radius=radius)
+        args=locals(),
+        constructor=go.Densitymapbox,
+        trace_patch=dict(radius=radius, opacity=opacity),
     )
 
 
diff --git a/packages/python/plotly/plotly/express/_core.py b/packages/python/plotly/plotly/express/_core.py
@@ -1278,9 +1278,7 @@ def infer_config(args, constructor, trace_patch):
         if args["opacity"] is None:
             if "barmode" in args and args["barmode"] == "overlay":
                 trace_patch["marker"] = dict(opacity=0.5)
-        elif constructor == go.Densitymapbox:
-            trace_patch["opacity"] = args["opacity"]
-        else:
+        elif constructor != go.Densitymapbox:
             trace_patch["marker"] = dict(opacity=args["opacity"])
     if "line_group" in args:
         trace_patch["mode"] = "lines" + ("+markers+text" if args["text"] else "")

Original file line number	Diff line number	Diff line change
`@@ -1089,7 +1089,9 @@ def density_mapbox(`
`1089`	`1089`	`the color of the region around the corresponding point on the map`
`1090`	`1090`	`"""`
`1091`	`1091`	`return make_figure(`
`1092`		`- args=locals(), constructor=go.Densitymapbox, trace_patch=dict(radius=radius)`
	`1092`	`+ args=locals(),`
	`1093`	`+ constructor=go.Densitymapbox,`
	`1094`	`+ trace_patch=dict(radius=radius, opacity=opacity),`
`1093`	`1095`	`)`
`1094`	`1096`
`1095`	`1097`