Skip to content

Commit d358954

Browse files
committed
Fix sqlalchemy flaky tests
1 parent 9d898a8 commit d358954

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

tests/integration/test_sqlalchemy_integration.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,9 @@ def test_insert(trino_connection):
102102
schema="test")
103103
metadata.create_all(engine)
104104
ins = users.insert()
105-
conn.execute(ins, {"id": 2, "name": "wendy", "fullname": "Wendy Williams"})
105+
result = conn.execute(ins, {"id": 2, "name": "wendy", "fullname": "Wendy Williams"})
106+
# TODO: Can we get rid of this?
107+
result.fetchall()
106108
query = sqla.select(users)
107109
result = conn.execute(query)
108110
rows = result.fetchall()
@@ -126,11 +128,13 @@ def test_insert_multiple_statements(trino_connection):
126128
schema="test")
127129
metadata.create_all(engine)
128130
ins = users.insert()
129-
conn.execute(ins, [
131+
result = conn.execute(ins, [
130132
{"id": 2, "name": "wendy", "fullname": "Wendy Williams"},
131133
{"id": 3, "name": "john", "fullname": "John Doe"},
132134
{"id": 4, "name": "mary", "fullname": "Mary Hopkins"},
133135
])
136+
# TODO: Can we get rid of this?
137+
result.fetchall()
134138
query = sqla.select(users)
135139
result = conn.execute(query)
136140
rows = result.fetchall()

0 commit comments

Comments
 (0)