Migrate away from atty

Author: smoelius

Cargo.lock

@@ -12,14 +12,14 @@ repository = "https://github.com/trailofbits/necessist"
 [dependencies]
 ansi_term = "0.12"
 anyhow = "1.0"
-atty = "0.2"
 bitflags = "2.3"
 clap = { version = "4.3", features = ["cargo", "derive"], optional = true }
 ctrlc = "3.4"
 diesel = { version = "2.1", features = ["sqlite"] }
 git2 = "0.17"
 heck = "0.4"
 indicatif = "0.17"
+is-terminal = "0.4"
 log = "0.4"
 once_cell = "1.18"
 proc-macro2 = { version = "1.0", features = ["span-locations"] }

core/Cargo.toml

@@ -8,6 +8,7 @@ use ansi_term::Style;
 use anyhow::{anyhow, bail, ensure, Result};
 use heck::ToKebabCase;
 use indicatif::ProgressBar;
+use is_terminal::IsTerminal;
 use log::debug;
 use std::{
     collections::BTreeMap,
@@ -129,7 +130,7 @@ pub fn necessist<Identifier: Applicable + Display + IntoEnumIterator + ToImpleme
     }
 
     let progress =
-        if var("RUST_LOG").is_err() && !context.opts.quiet && atty::is(atty::Stream::Stdout) {
+        if var("RUST_LOG").is_err() && !context.opts.quiet && std::io::stdout().is_terminal() {
             Some(ProgressBar::new(n_spans as u64))
         } else {
             None
@@ -539,7 +540,7 @@ fn emit_to_console(context: &LightContext, removal: &Removal) {
             "{}: `{}` {}",
             span.to_console_string(),
             text,
-            if atty::is(atty::Stream::Stdout) {
+            if std::io::stdout().is_terminal() {
                 outcome.style().bold()
             } else {
                 Style::default()

core/src/core.rs

@@ -6,6 +6,7 @@ use ansi_term::{
 use anyhow::{bail, Result};
 use bitflags::bitflags;
 use heck::ToKebabCase;
+use is_terminal::IsTerminal;
 use std::{collections::BTreeMap, sync::Mutex};
 
 // smoelius: `Warning` is part of Necessist's public API. Please try to follow the naming convention
@@ -142,7 +143,7 @@ Silence this warning with: --allow {warning}"
             "{}: ",
             source.to_console_string()
         )),
-        if atty::is(atty::Stream::Stdout) {
+        if std::io::stdout().is_terminal() {
             Yellow.bold()
         } else {
             Style::default()
@@ -164,7 +165,7 @@ pub(crate) fn note(context: &LightContext, msg: &str) {
 
     (context.println)(&format!(
         "{}: {}",
-        if atty::is(atty::Stream::Stdout) {
+        if std::io::stdout().is_terminal() {
             Green.bold()
         } else {
             Style::default()