Skip to content

[$50] 'Salutes' count is not updating when user click on 'Salute' button #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sdgun opened this issue Jun 21, 2018 · 6 comments
Closed

Comments

@sdgun
Copy link

sdgun commented Jun 21, 2018

Target URL

https://frontend.app.cloud.gov/dashboard/10

Steps to Reproduce

  1. Open the URL https://frontend.app.cloud.gov/
  2. Login as a valid User [Admin]
  3. Click Search button
  4. Enter 'Branch of service' as US NAVY
  5. Click 'Update Results' button
  6. Click on any record > https://frontend.app.cloud.gov/dashboard/10
  7. Click on 'Stories' section and click on 'Read more' from one of the stories
  8. Check the 'Salutes' count > 489
  9. Click on the 'Salute' button
  10. Check the 'Salutes' count > 489

Actual Result(s)

  • 'Salutes' count is not updating when user click on 'Salute' button

Expected Result(s)

  • Must increase the count of the 'Salutes' when user click on the 'Salute' button

Frequency

  • 5/5

Environment Details

  • Device(s): Laptop
  • Operating System: Windows 7 64bit
  • Browser(s): Chrome 67.0.3396.87 (Official Build) (64-bit)

Image(s)/Video(s)/Console Log/Crash Log

24

@ramillim
Copy link
Contributor

@dustinWeaver could you add a task dependency for this issue on the rest-api project? of the 3 (reads, salutes, and shares), only salutes is even implemented on backend.

This issue will be blocked until that's completed.

@ramillim
Copy link
Contributor

In the meantime, this one also has a design decision:
I think that when this is implemented, clicking on salute should just increment the number by 1 instead of getting the actual number from the backend. I think that will make it snappier instead of having to wait for the response and avoid confusion when the number goes up by more than one because other people saluted at the same time.

When the post is reloaded with a fetch from the server, it can then provide whatever the current number is (or cached number depending on how it is implemented).

@dustinWeaver
Copy link

Thanks @ramillim, I've added the issue on the rest-api repo.

I'll tag this as "phase 2" as well.

@ramillim ramillim mentioned this issue Jul 25, 2018
@dustinTopcoder dustinTopcoder changed the title 'Salutes' count is not updating when user click on 'Salute' button [$50] 'Salutes' count is not updating when user click on 'Salute' button Aug 16, 2018
@MountainGoats MountainGoats added the Priority 4 Low - Fixed only when time permits label Aug 16, 2018
@dustinTopcoder
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30069624 has been created for this ticket.

@dustinTopcoder
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30069624 has been updated - the new changes has been updated for this ticket.

@ksmacleod99
Copy link
Collaborator

Resolved in PR #90

@ksmacleod99 ksmacleod99 added Paid and removed Open for pickup Priority 4 Low - Fixed only when time permits labels Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants