fix: use uppercase reviewType

to match changes in Challenge API

Author: maxceem

src/components/ChallengeEditor/ChallengeView/index.js

@@ -22,7 +22,7 @@ import LegacyLinks from '../../LegacyLinks'
 import AssignedMemberField from '../AssignedMember-Field'
 import { getResourceRoleByName } from '../../../util/tc'
 import Tooltip from '../../Tooltip'
-import { MESSAGE } from '../../../config/constants'
+import { MESSAGE, REVIEW_TYPES } from '../../../config/constants'
 
 const ChallengeView = ({
   projectDetail,
@@ -59,9 +59,9 @@ const ChallengeView = ({
   copilot = copilot || copilotFromResources
   reviewer = reviewer || reviewerFromResources
 
-  const reviewType = challenge.reviewType ? challenge.reviewType.toLowerCase() : 'community'
-  const isCommunity = reviewType === 'community'
-  const isInternal = reviewType === 'internal'
+  const reviewType = challenge.reviewType ? challenge.reviewType.toUpperCase() : REVIEW_TYPES.COMMUNITY
+  const isCommunity = reviewType === REVIEW_TYPES.COMMUNITY
+  const isInternal = reviewType === REVIEW_TYPES.INTERNAL
   const timeLineTemplate = _.find(metadata.timelineTemplates, { id: challenge.timelineTemplateId })
   if (isLoading || _.isEmpty(metadata.challengePhases) || challenge.id !== challengeId) return <Loader />
   const showTimeline = false // disables the timeline for time being https://github.com/topcoder-platform/challenge-engine-ui/issues/706

src/components/ChallengeEditor/ReviewType-Field/index.js

@@ -10,7 +10,7 @@ const ReviewTypeField = ({ reviewers, challenge, onUpdateOthers, onUpdateSelect
   const isDesignChallenge = challenge.trackId === DES_TRACK_ID
   const isQAChallenge = challenge.trackId === QA_TRACK_ID
   const defaultReviewType = isDesignChallenge ? REVIEW_TYPES.INTERNAL : REVIEW_TYPES.COMMUNITY
-  const reviewType = challenge.reviewType ? challenge.reviewType.toLowerCase() : defaultReviewType
+  const reviewType = challenge.reviewType ? challenge.reviewType.toUpperCase() : defaultReviewType
   const isCommunity = reviewType === REVIEW_TYPES.COMMUNITY
   const isInternal = reviewType === REVIEW_TYPES.INTERNAL
   const communityOption = (disabled) => (<div className={styles.tcRadioButton}>

src/components/ChallengeEditor/index.js

@@ -651,8 +651,8 @@ class ChallengeEditor extends Component {
       return !!name && !!trackId && !!typeId
     }
 
-    const reviewType = challenge.reviewType ? challenge.reviewType.toLowerCase() : 'community'
-    const isInternal = reviewType === 'internal'
+    const reviewType = challenge.reviewType ? challenge.reviewType.toUpperCase() : REVIEW_TYPES.COMMUNITY
+    const isInternal = reviewType === REVIEW_TYPES.INTERNAL
     if (isInternal && !challenge.reviewer) {
       return false
     }

src/config/constants.js

@@ -111,8 +111,8 @@ export const PRIZE_SETS_TYPE = {
 }
 
 export const REVIEW_TYPES = {
-  INTERNAL: 'internal',
-  COMMUNITY: 'community'
+  INTERNAL: 'INTERNAL',
+  COMMUNITY: 'COMMUNITY'
 }
 
 // List of subtracks that should be considered as Marathon Matches