Skip to content

Commit 961c209

Browse files
committed
Forum link showing incorrectly
#1512 #1511
1 parent fa56589 commit 961c209

File tree

5 files changed

+16
-10
lines changed

5 files changed

+16
-10
lines changed

src/actions/sidebar.js

+9-3
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,14 @@
22
* Sidebar related redux actions
33
*/
44
import { fetchMemberProjects } from '../services/projects'
5-
import { SET_ACTIVE_PROJECT, LOAD_PROJECTS_FAILURE, LOAD_PROJECTS_PENDING, LOAD_PROJECTS_SUCCESS, RESET_SIDEBAR_ACTIVE_PARAMS } from '../config/constants'
5+
import {
6+
SET_ACTIVE_PROJECT,
7+
LOAD_PROJECTS_FAILURE,
8+
LOAD_PROJECTS_PENDING,
9+
LOAD_PROJECTS_SUCCESS,
10+
RESET_SIDEBAR_ACTIVE_PARAMS,
11+
UNLOAD_PROJECTS_SUCCESS
12+
} from '../config/constants'
613
import _ from 'lodash'
714

815
/**
@@ -58,8 +65,7 @@ export function loadProjects (filterProjectName = '', myProjects = true) {
5865
export function unloadProjects () {
5966
return (dispatch) => {
6067
dispatch({
61-
type: LOAD_PROJECTS_SUCCESS,
62-
projects: []
68+
type: UNLOAD_PROJECTS_SUCCESS
6369
})
6470
}
6571
}

src/components/ChallengesComponent/ChallengeCard/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ class ChallengeCard extends React.Component {
323323
<a className={styles.link} href={communityAppUrl} target='_blank'>CA</a>
324324
</div>
325325
<div className={styles.col6}>
326-
{forumLink ? (<a className={styles.link} href={forumLink} target='_blank'>CA</a>)
326+
{forumLink ? (<a className={styles.link} href={forumLink} target='_blank'>Forum</a>)
327327
: (<a className={styles.link} href='javascript:void(0)'>Forum</a>)}
328328
</div>
329329
</div>

src/config/constants.js

+1
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ export const getAWSContainerFileURL = (key) => `https://${FILE_PICKER_CONTAINER_
5555
export const LOAD_PROJECTS_SUCCESS = 'LOAD_PROJECTS_SUCCESS'
5656
export const LOAD_PROJECTS_PENDING = 'LOAD_PROJECTS_PENDING'
5757
export const LOAD_PROJECTS_FAILURE = 'LOAD_PROJECTS_FAILURE'
58+
export const UNLOAD_PROJECTS_SUCCESS = 'UNLOAD_PROJECTS_SUCCESS'
5859

5960
// project billingAccount
6061
export const LOAD_PROJECT_BILLING_ACCOUNT = 'LOAD_PROJECT_BILLING_ACCOUNT'

src/containers/Users/index.js

-4
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import { connect } from 'react-redux'
33
import _ from 'lodash'
44
import PT from 'prop-types'
55
import UsersComponent from '../../components/Users'
6-
import { loadProjects } from '../../actions/sidebar'
76
import { loadProject, reloadProjectMembers } from '../../actions/projects'
87
import { PROJECT_ROLES } from '../../config/constants'
98

@@ -17,7 +16,6 @@ class Users extends Component {
1716
}
1817

1918
componentDidMount () {
20-
this.props.loadProjects()
2119
}
2220

2321
isEditable () {
@@ -76,13 +74,11 @@ const mapStateToProps = ({ sidebar, challenges, auth, projects }) => {
7674

7775
const mapDispatchToProps = {
7876
loadProject,
79-
loadProjects,
8077
reloadProjectMembers
8178
}
8279

8380
Users.propTypes = {
8481
loadProject: PT.func.isRequired,
85-
loadProjects: PT.func.isRequired,
8682
reloadProjectMembers: PT.func.isRequired,
8783
projects: PT.arrayOf(PT.object),
8884
projectMembers: PT.arrayOf(PT.object),

src/reducers/sidebar.js

+5-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ import {
66
LOAD_PROJECTS_SUCCESS,
77
LOAD_PROJECTS_PENDING,
88
LOAD_PROJECTS_FAILURE,
9-
RESET_SIDEBAR_ACTIVE_PARAMS
9+
RESET_SIDEBAR_ACTIVE_PARAMS,
10+
UNLOAD_PROJECTS_SUCCESS
1011
} from '../config/constants'
1112

1213
const initialState = {
@@ -19,9 +20,11 @@ const initialState = {
1920
export default function (state = initialState, action) {
2021
switch (action.type) {
2122
case SET_ACTIVE_PROJECT:
22-
return { ...state, activeProjectId: action.projectId, projects: [], isLoading: false }
23+
return { ...state, activeProjectId: action.projectId, projects: [], isLoading: false, isLoadProjectsSuccess: false }
2324
case LOAD_PROJECTS_SUCCESS:
2425
return { ...state, projects: action.projects, isLoading: false, isLoggedIn: true, isLoadProjectsSuccess: true }
26+
case UNLOAD_PROJECTS_SUCCESS:
27+
return { ...state, projects: [], isLoading: false, isLoggedIn: true, isLoadProjectsSuccess: false }
2528
case LOAD_PROJECTS_PENDING:
2629
return { ...state, isLoading: true }
2730
case LOAD_PROJECTS_FAILURE:

0 commit comments

Comments
 (0)