Skip to content

Commit 749d3f7

Browse files
author
Vikas Agarwal
committed
fix: git#877-Summary validation error don't go away when all individual validations are off
1 parent 9642b32 commit 749d3f7

File tree

1 file changed

+15
-5
lines changed

1 file changed

+15
-5
lines changed

src/components/ChallengeEditor/index.js

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,9 @@ class ChallengeEditor extends Component {
282282
}
283283

284284
// calculate total cost of challenge
285-
this.setState({ challenge: newChallenge })
285+
this.setState({ challenge: newChallenge }, () => {
286+
this.validateChallenge()
287+
})
286288
}
287289

288290
/**
@@ -331,7 +333,9 @@ class ChallengeEditor extends Component {
331333
newChallenge[field][index][option.key] = option.name
332334
}
333335
}
334-
this.setState({ challenge: newChallenge })
336+
this.setState({ challenge: newChallenge }, () => {
337+
this.validateChallenge()
338+
})
335339
}
336340
}
337341

@@ -350,7 +354,9 @@ class ChallengeEditor extends Component {
350354
value = value.filter(val => _.values(PRIZE_SETS_TYPE).includes(val.type))
351355
}
352356
newChallenge[field] = value
353-
this.setState({ challenge: newChallenge })
357+
this.setState({ challenge: newChallenge }, () => {
358+
this.validateChallenge()
359+
})
354360
}
355361

356362
/**
@@ -388,7 +394,9 @@ class ChallengeEditor extends Component {
388394
} else {
389395
_.set(newChallenge, `${field}.${index}.check`, checked)
390396
}
391-
this.setState({ challenge: newChallenge })
397+
this.setState({ challenge: newChallenge }, () => {
398+
this.validateChallenge()
399+
})
392400
}
393401

394402
/**
@@ -668,7 +676,9 @@ class ChallengeEditor extends Component {
668676
let newChallenge = { ...challenge }
669677
newChallenge[field] = options ? options.split(',') : []
670678

671-
this.setState({ challenge: newChallenge })
679+
this.setState({ challenge: newChallenge }, () => {
680+
this.validateChallenge()
681+
})
672682
}
673683

674684
onUpdatePhase (newValue, property, index) {

0 commit comments

Comments
 (0)