Fix of Link and NavLink

Fix for #25

Author: birdofpreyru

__tests__/shared/components/GenericLink.jsx

@@ -1,4 +1,4 @@
-/* global document, window */
+/* global window */
 
 import GenericLink from 'components/GenericLink';
 import PT from 'prop-types';
@@ -83,7 +83,6 @@ test('onClick(..) works when rendered as custom <Link>', () => {
   expect(clickHandler).toHaveBeenCalled();
 
   const domain = 'https://some.domain.com';
-  document.location.assign = jest.fn();
   doc = renderDom((
     <GenericLink
       className="LINK"
@@ -96,6 +95,5 @@ test('onClick(..) works when rendered as custom <Link>', () => {
   link = findInDomByClass(doc, 'LINK');
   simulate.click(link);
 
-  expect(document.location.assign).toHaveBeenCalledWith(domain);
   expect(window.scroll).toHaveBeenCalledTimes(1);
 });

package-lock.json

@@ -121,5 +121,5 @@
     "mkDistDir:prod": "mkdir -p dist/prod/shared/utils && mkdir -p dist/prod/client",
     "test": "npm run lint && npm run jest"
   },
-  "version": "0.7.0"
+  "version": "0.7.1"
 }

package.json

@@ -6,7 +6,7 @@
  * - User explicitely opts to use <a>.
  */
 
-/* global document, window */
+/* global window */
 
 import _ from 'lodash';
 import PT from 'prop-types';
@@ -25,9 +25,12 @@ export default function GenericLink(props) {
     routerLinkType,
     to,
   } = props;
+
+  const url = new Url(to);
+
   /* Renders the link as <a> element if either opted explicitely, or the link
    * should open a new tab, or it is an anchor reference. */
-  if (enforceA || openNewTab || to.startsWith('#')) {
+  if (enforceA || openNewTab || to.startsWith('#') || url.host) {
     return (
       <a
         className={className}
@@ -56,17 +59,7 @@ export default function GenericLink(props) {
     onClick: (e) => {
       /* If a custom onClick(..) handler was provided we execute it. */
       if (onClick) onClick(e);
-
-      /* If the URL leads to a different domain we make transition using JS,
-        * preventing event processing by React Router. */
-      const url = new Url(to);
-      if (url.origin !== document.location.origin) {
-        document.location.assign(to);
-        e.preventDefault();
-
-      /* Scroll to the top-left corner of the page, just in case the link
-        * references the same page we are already in. */
-      } else window.scroll(0, 0);
+      window.scroll(0, 0);
     },
   }, children);
 }