From 7cca2afb54e725f0b1f7f29afdb138aa8cdccc1c Mon Sep 17 00:00:00 2001
From: "Luiz R. Rodrigues" <contato@luizrrodrigues.com.br>
Date: Thu, 13 Aug 2020 21:44:51 -0300
Subject: [PATCH] Fix challenge.track validation

---
 src/reducers/challenge.js     | 4 +++-
 src/services/challenges.js    | 4 ++--
 src/utils/challenge/filter.js | 2 +-
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/reducers/challenge.js b/src/reducers/challenge.js
index 05bb9bc9..e91c4f53 100644
--- a/src/reducers/challenge.js
+++ b/src/reducers/challenge.js
@@ -18,6 +18,8 @@ import { fireErrorMessage } from '../utils/errors';
 
 import mySubmissionsManagement from './my-submissions-management';
 
+import { COMPETITION_TRACKS } from '../utils/tc';
+
 /**
  * Handles CHALLENGE/GET_DETAILS_INIT action.
  * @param {Object} state
@@ -469,7 +471,7 @@ export function factory(options = {}) {
       const challengeDetails = _.get(res, 'payload', {});
       const track = _.get(challengeDetails, 'legacy.track', '');
       let checkpointsPromise = null;
-      if (track === 'DESIGN') {
+      if (track === COMPETITION_TRACKS.DESIGN) {
         const p = _.get(challengeDetails, 'phases', [])
           .filter(x => x.name === 'Checkpoint Review');
         if (p.length && !p[0].isOpen) {
diff --git a/src/services/challenges.js b/src/services/challenges.js
index f24bdf5e..d5fb3bc2 100644
--- a/src/services/challenges.js
+++ b/src/services/challenges.js
@@ -636,7 +636,7 @@ class ChallengesService {
     let contentType;
     let url;
 
-    if (track === 'DESIGN') {
+    if (track === COMPETITION_TRACKS.DESIGN) {
       ({ api } = this.private);
       contentType = 'application/json';
       url = '/submissions/'; // The submission info is contained entirely in the JSON body
@@ -654,7 +654,7 @@ class ChallengesService {
     }, onProgress).then((res) => {
       const jres = JSON.parse(res);
       // Return result for Develop submission
-      if (track === 'DEVELOP') {
+      if (track === COMPETITION_TRACKS.DEVELOP) {
         return jres;
       }
       // Design Submission requires an extra "Processing" POST
diff --git a/src/utils/challenge/filter.js b/src/utils/challenge/filter.js
index 36e91e6f..263c3132 100644
--- a/src/utils/challenge/filter.js
+++ b/src/utils/challenge/filter.js
@@ -89,7 +89,7 @@ function filterByRegistrationOpen(challenge, state) {
     if (!registrationPhase || !registrationPhase.isOpen) {
       return false;
     }
-    if (challenge.track === 'DESIGN') {
+    if (challenge.track === COMPETITION_TRACKS.DESIGN) {
       const checkpointPhase = challengePhases.find(item => item.name === 'Checkpoint Submission')[0];
       return !checkpointPhase || !checkpointPhase.isOpen;
     }