Skip to content

[$200] Code quality improvements #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ThomasKranitsas opened this issue Dec 20, 2018 · 7 comments
Closed

[$200] Code quality improvements #36

ThomasKranitsas opened this issue Dec 20, 2018 · 7 comments

Comments

@ThomasKranitsas
Copy link
Contributor

  1. I think this whole thing can be rewritten using API factory function. And usage will be like
const { getApi } = services.api;
const api = getApi(version='V4',tokenV3)

This might need change on the community app side but it will generic for next versions.

  1. I think we should remove every mention of v4 from the docs, there are many places where there is v4. Probably in a month or two, we will be launching v5
    https://github.com/topcoder-platform/topcoder-react-lib/pull/33/files search for v4
@ThomasKranitsas
Copy link
Contributor Author

Contest https://www.topcoder.com/challenges/30077593 has been created for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@ThomasKranitsas ThomasKranitsas self-assigned this Dec 20, 2018
@ThomasKranitsas
Copy link
Contributor Author

Contest https://www.topcoder.com/challenges/30077593 has been updated - it has been assigned to thomaskranitsas.

This is an automated message for thomaskranitsas via Topcoder X

@sushilshinde
Copy link
Collaborator

sushilshinde commented Jan 28, 2019

Issue# 1

@ThomasKranitsas I found this issue on

Community-app#lib-test branch and topcoder-react-lib#code-quality-fixes branches

https://test-community-app.topcoder-dev.com/challenges

topcoder challenges 2019-01-28 16-40-02

https://beta-community-app.topcoder.com/challenges

topcoder challenges 2019-01-28 17-11-54

@ThomasKranitsas
Copy link
Contributor Author

@sushilshinde
Could this be a temporary issue?
Maybe had to do with caching?

I can't reproduce it.
See screenshots below:

screenshot 2019-01-28 at 18 02 25

screenshot 2019-01-28 at 18 02 36

@ThomasKranitsas ThomasKranitsas changed the title [$80] Code quality improvements [$200] Code quality improvements Feb 4, 2019
@ThomasKranitsas
Copy link
Contributor Author

Contest https://www.topcoder.com/challenges/30077593 has been updated - the new changes has been updated for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@ThomasKranitsas
Copy link
Contributor Author

@sushilshinde is this good to close?

@ThomasKranitsas
Copy link
Contributor Author

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30077593

This is an automated message for thomaskranitsas via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants