Removed hardcoded challenge typeId

Added getChallengeTypeId() to get challenge id by abbreviation

Author: luizrrodrigues

src/services/challenges.js

@@ -340,6 +340,22 @@ class ChallengesService {
       ));
   }
 
+  /**
+   * Get the ID from a challenge type by abbreviation
+   * @param {String} abbreviation
+   * @return {Promise} ID from first abbreviation match
+   */
+  async getChallengeTypeId(abbreviation) {
+    const ret = await this.private.apiV5.get(`/challenge-types?abbreviation=${abbreviation}`)
+      .then(checkErrorV5).then(res => res);
+
+    if (_.isEmpty(ret.result)) {
+      throw new Error('Challenge typeId not found!');
+    }
+
+    return ret.result[0].id;
+  }
+
   /**
    * Gets possible challenge tags (technologies).
    * @return {Promise} Resolves to the array of tag strings.
@@ -375,7 +391,17 @@ class ChallengesService {
    * @return {Promise}
    */
   async getSrms(params) {
-    const res = await this.private.apiV5.get(`/challenges/?${qs.stringify(params)}`);
+    const typeId = await this.getChallengeTypeId('DEVELOP_SINGLE_ROUND_MATCH');
+    if (!typeId) {
+      return null;
+    }
+
+    const newParams = {
+      ...params,
+      typeId,
+    };
+
+    const res = await this.private.apiV5.get(`/challenges?${qs.stringify(newParams)}`);
     return getApiResponsePayload(res);
   }
 
@@ -415,17 +441,25 @@ class ChallengesService {
 
   /**
    * Gets marathon matches of the specified user.
-   * @param {String} userId User whose challenges we want to fetch.
-   * @param {Object} filters Optional.
-   * @param {Number} params Optional.
+   * @param {String} memberId User whose challenges we want to fetch.
+   * @param {Object} params
    * @return {Promise} Resolves to the api response.
    */
-  async getUserMarathonMatches(userId) {
-    const marathonTypeId = 'c2579605-e294-4967-b3db-875ef85240cd';
-    const url = `/challenges?typeId=${marathonTypeId}&memberId=${userId}`;
+  async getUserMarathonMatches(memberId, params) {
+    const typeId = await this.getChallengeTypeId('DEVELOP_MARATHON_MATCH');
+
+    if (!typeId) {
+      return null;
+    }
 
-    const res = await this.private.apiV5.get(url);
-    return res;
+    const newParams = {
+      ...params,
+      typeId,
+      memberId,
+    };
+
+    const res = await this.private.apiV5.get(`/challenges?${qs.stringify(newParams)}`);
+    return getApiResponsePayload(res);
   }
 
   /**
@@ -435,18 +469,19 @@ class ChallengesService {
    * @return {Promise}
    */
   async getUserSrms(memberId, params) {
-    const challenges = await this.private.apiV5.get(`/resources/${memberId}/challenges`);
-    let newParams = params;
-    if (challenges) {
-      const { challengeId } = challenges[0];
-      newParams = {
-        ...params,
-        challengeId,
-      };
+    const typeId = await this.getChallengeTypeId('DEVELOP_SINGLE_ROUND_MATCH');
+
+    if (!typeId) {
+      return null;
     }
 
-    const url = `/challenges/${qs.stringify(newParams)}`;
-    const res = await this.private.apiV5.get(url);
+    const newParams = {
+      ...params,
+      typeId,
+      memberId,
+    };
+
+    const res = await this.private.apiV5.get(`/challenges?${qs.stringify(newParams)}`);
     return getApiResponsePayload(res);
   }