Skip to content

Commit 942af6e

Browse files
authored
Merge pull request #177 from simranb86/issue_4435
fix for Issue #4435
2 parents be906cf + 75f81f9 commit 942af6e

File tree

2 files changed

+20
-2
lines changed

2 files changed

+20
-2
lines changed

src/reducers/challenge.js

+9-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,15 @@ function onGetDetailsDone(state, action) {
6262
}
6363

6464
const details = action.payload;
65-
if (_.toString(details.id) !== state.loadingDetailsForChallengeId) {
65+
66+
// condition based on ROUTE used for Review Opportunities, change if needed
67+
const challengeId = state.loadingDetailsForChallengeId;
68+
let compareChallenge = details.id;
69+
if (challengeId.length >= 5 && challengeId.length <= 8) {
70+
compareChallenge = details.legacyId;
71+
}
72+
73+
if (_.toString(compareChallenge) !== challengeId) {
6674
return state;
6775
}
6876

src/services/challenges.js

+11-1
Original file line numberDiff line numberDiff line change
@@ -319,10 +319,20 @@ class ChallengesService {
319319
* @return {Promise} Resolves to the challenge object.
320320
*/
321321
async getChallengeDetails(challengeId) {
322-
const challengeFiltered = await this.private.getChallenges('/challenges/', { id: challengeId })
322+
let isLegacyChallenge = false;
323+
const filters = {};
324+
// condition based on ROUTE used for Review Opportunities, change if needed
325+
if (challengeId.length >= 5 && challengeId.length <= 8) {
326+
isLegacyChallenge = true;
327+
filters.legacyId = challengeId;
328+
} else {
329+
filters.id = challengeId;
330+
}
331+
const challengeFiltered = await this.private.getChallenges('/challenges/', filters)
323332
.then(res => res.challenges[0]);
324333

325334
if (challengeFiltered) {
335+
challengeFiltered.isLegacyChallenge = isLegacyChallenge;
326336
const { events } = challengeFiltered.metadata;
327337
if (events) {
328338
challengeFiltered.events = _.map(events, e => ({

0 commit comments

Comments
 (0)