Skip to content

Commit 80a9b71

Browse files
committed
fix(ChallengeDetails): return userDetails.roles with challenge details
1 parent 70e97da commit 80a9b71

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"lint:js": "./node_modules/.bin/eslint --ext .js,.jsx .",
3232
"test": "npm run lint && npm run jest"
3333
},
34-
"version": "1000.19.39",
34+
"version": "1000.19.40",
3535
"dependencies": {
3636
"auth0-js": "^6.8.4",
3737
"config": "^3.2.0",

src/services/challenges.js

+6-2
Original file line numberDiff line numberDiff line change
@@ -327,6 +327,7 @@ class ChallengesService {
327327
let submissions = [];
328328
let isLegacyChallenge = false;
329329
let isRegistered = false;
330+
const userDetails = { roles: [] };
330331

331332
// condition based on ROUTE used for Review Opportunities, change if needed
332333
if (/^[\d]{5,8}$/.test(challengeId)) {
@@ -372,6 +373,7 @@ class ChallengesService {
372373
}
373374
});
374375
}
376+
userDetails.roles = await this.getUserRolesInChallenge(challengeId);
375377
}
376378

377379
challenge = {
@@ -380,6 +382,7 @@ class ChallengesService {
380382
isRegistered,
381383
registrants,
382384
submissions,
385+
userDetails,
383386
events: _.map(challenge.events, e => ({
384387
eventName: e.key,
385388
eventId: e.id,
@@ -703,8 +706,9 @@ class ChallengesService {
703706
*/
704707
async getUserRolesInChallenge(challengeId) {
705708
const user = decodeToken(this.private.tokenV3);
706-
const url = `/resources?challengeId=${challengeId}?memberHandle=${user.handle}`;
707-
const resources = await this.private.apiV5.get(url);
709+
const url = `/resources?challengeId=${challengeId}&memberHandle=${user.handle}`;
710+
const getResourcesResponse = await this.private.apiV5.get(url);
711+
const resources = await getResourcesResponse.json();
708712
if (resources) return _.map(resources, 'roleId');
709713
throw new Error(`Failed to fetch user role from challenge #${challengeId}`);
710714
}

0 commit comments

Comments
 (0)