Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 43c61a5

Browse files
authoredDec 11, 2019
Merge pull request #119 from topcoder-platform/develop
Submission Tab for MM are not filtering scores from Virus Scan and showing `100` score
2 parents 5f528e0 + 8c70aae commit 43c61a5

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed
 

‎package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,16 @@
2222
},
2323
"scripts": {
2424
"build": "npm run clean && npm run build:dev && npm run build:prod",
25-
"build:dev": "./node_modules/.bin/webpack --env=development --progress --profile --colors --display-optimization-bailout",
25+
"build:dev": "NODE_ENV=development ./node_modules/.bin/webpack --env=development --progress --profile --colors --display-optimization-bailout",
2626
"build:dev:watch": "npm run clean && ./node_modules/.bin/webpack --env=development --progress --profile --colors --watch --display-optimization-bailout",
27-
"build:prod": "./node_modules/.bin/webpack --env=production --progress --profile --colors --display-optimization-bailout",
27+
"build:prod": "NODE_ENV=production ./node_modules/.bin/webpack --env=production --progress --profile --colors --display-optimization-bailout",
2828
"clean": "rimraf dist",
2929
"jest": "jest --no-cache --maxWorkers=4 --config config/jest/default.js",
3030
"lint": "npm run lint:js",
3131
"lint:js": "./node_modules/.bin/eslint --ext .js,.jsx .",
3232
"test": "npm run lint && npm run jest"
3333
},
34-
"version": "0.9.1",
34+
"version": "0.10.0",
3535
"dependencies": {
3636
"auth0-js": "^6.8.4",
3737
"config": "^3.2.0",

‎src/utils/submission.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,7 @@ export function processMMSubmissions(submissions, resources, registrants) {
134134
if (!data[memberHandle]) {
135135
data[memberHandle] = [];
136136
}
137-
const validReviews = _.filter(submission.review,
138-
r => !_.isEmpty(r) && (r.typeId !== AV_SCAN_SCORER_REVIEW_TYPE_ID));
137+
const validReviews = _.reject(submission.review, ['typeId', AV_SCAN_SCORER_REVIEW_TYPE_ID]);
139138
validReviews.sort((a, b) => {
140139
const dateA = new Date(a.created);
141140
const dateB = new Date(b.created);

0 commit comments

Comments
 (0)
Please sign in to comment.